test/testnagg.sh: added explanation of available test script functions.
began adding test ids to tests for matching with requirements document
test/nagg_functions.sh added parameter to h5dump_grep option for future use of grep options
src/nagg_write_granules.c added H5Rdefeference_ macro coutesy of Scot Breitenfeld to call the
correct H5Rdereference version for HDF5 1.8 or HDF5 1.9(1.10).
src/nagg_options.c added long...
Update nagg version 1.6.1 release date.
Check object ids with H5Iis_valid before closing at end of functions.
Tested on jam, koala and platypus with gcc and icc.
nagg.h
increased size of NAGG_Product_Path_size from 79 to 128 to eliminate segmentation fault for a product with a long name.
nagg_get_granules.c
added debug code to print numbers of open objects immediately before calling H5Fclose().
nagg_write_granules.c
added debug code to print numbers of open objects immediately before calling H5Fclose().
added code to close input files only when opening a different input file for a product or when the highest indexed granule for a produ...
nagg_write_granules.c
Output files were not closed due to open groups and attributes. These are now closed.
This became apparent when attempting to deaggregate the file resulting from the aggregation and packaging of 136 granules of 16 VIIRS products + GEO, which exceeded the 1024 system limit for open files.
test script and files
Increased the aggregation number to 129 to get a full bucket in the output of the 1885 granules test.
Saved the output file of the test and added a...
nagg_write_granules.c
Refactored code to extract create_granule_regrefs() function from copy_granule_hyperslabs.
Added missing function comment headers.
RELEASE.txt
Added entries for JPSS-86 and JPSS-87 fixes.
nagg_get_granules.c
toofewgranules.txt
Test failed when make check was run for a build configured with an absolute path to configure
instead of a relative path. Removed the path from the error message so the expected output
for the test w...
Fixed JPSS-86 and JPSS-87. Region references are now created for hyperslabs with no stored data because they contain entirely fill values. nagg will now handle files that have missing region references and create the missing references in the output files.
While addressing these issues, a file was created with a 12 granule aggregation but only one granule dataset in the /Data_Products group. The file was not corrupted, but nagg failed when it could not find expected granule datasets. Th...
Initial fix for JPSS-86 and JPSS-87. Region references are now created for hyperslabs that have only fill values, even though no data is written to the hyperslab.
Code is still needed to create missing references that were not written by an earlier version of nagg.
Some memory leaks were also addressed, but others remain.
Tested on jam and platypus with gcc & icc.
Raised limit for products to 42. There are potentially 50 products that could be packaged, but more than
42 will create a filename too long for the 255 character limit on Linux machines.
Raised limit of granules selected to 2200.
Modified tests for the new limits.
Tested jam & koala.
Check in code changes that check for incompatible layout and filter options when parsing the command, avoiding a failure later on when the new dataset is created
COMPACT layout has a builtin maximum size in HDF5 and should not have a minimum size applied.
Datasets specified by name for --layout or --filter options will not have minimum size applied.
Tested with gcc and icc on 32bit and 64bit Linux (jam and platypus)
Add new tests for layout/filter combinations to testnagg.sh.
Add option to run grep on output of h5dump to nagg_functions.sh.
Expected output files for tests with multiple layout or filter changes.
test/testfiles/gcrio-mixed-applycompactGZIP.txt
test/testfiles/gcrio-mixed-applyccNONEmin.txt
test/testfiles/gcrio-mixed-applycompactcontiguous.txt
test/testfiles/gcrio-mixed-applycompact-all.txt
test/testfiles/gcrio-mixed-applycontigSHUF.txt
The new tests are expected to fail...
test/testfiles/*
Update expected output files for new command line options.
test/testnagg.sh
Add --minimum=1 parameter for tests of COMPACT layout.
configure
configure.ac
README
doc/RELEASE.txt
src/nagg.h
Update version to 1.6.0-beta
src/nagg_options.c
Update usage message for new command line options (--filter, --layout, --minimum).
src/nagg_filayopt.c
src/nagg_filayopt.h
Add default minimum size 1024 byte for datasets to which filter and layout options
will be applie...
src/nagg_select_granules.c
nagg_main.c
nagg.h
corrected a few typos and spacing
nagg_write_granules.c
added code to write HDF5 userblocks for NPP files.
test/testnagg.sh
commented out a test applying contiguous layout to several datasets. The ouput includes
an offset value that is not the same from one run to another. This test will need
further filtering capability in the nagg test scripts.
Add tests for --layout, --filter and --minimum options. They will fail in this revision, and pass in the next revision when the code is checked in.
Tested jam, koala, platypus ith gcc and icc.
nagg_filayopt.h
nagg_filayopt.c
nagg_filayopt_parse.c
nagg_filayopt_table.c
New files copied from h5repack to parse new --layout, --filter, and --minimum options.
nagg.h
nagg_main.c
nagg_options.c
Makefile.in
src/Makefile.am
Changes to integrate new command line options above.
nagg_posix.h
Add additional HD macros from HDF5
Tested jam and koala, gcc and icc.
nagg_write_granules.c
move code that applies command line --layout option changes while creating datasets to a separate function.
Tested on jam & koala, gcc & icc and extensive file tests.
Merge new tests for --layout option from compression branch.
Add h5dump option to TOOLTEST function in test/nagg_functions.sh
make check will fail in this revision, but pass in the next.
Fill Values do not need to be written if all the data in a dataset consists solely of fill values.
Added code to check for datasets with storage size 0 and skip copying the granule hyperslabs for that dataset. Also removed writing of fill values in datasets for missing granules. It may be possible to check each hyperslab to see if the data is entirely fill values before writing it, even if other hyperslabs have real data, but that has not been done in this checkin.
Tested on jam & koala, ...
gaero_products.c
expected output file for test of products with GAERO geolocation.
RELEASE.txt
Add that nagg produces a segmentation fault when output files fill the disk.