Updated RELEASE.txt for "-g no" implementation and aggregation of geoproducts.
Also added current Jira issues.
-This line, and those below, will be ignored--
M RELEASE.txt
Check in changes for initial implementation of "-g no".
nagg_main.c
Added total_nproducts = nproducts with -g no or nproducts+1 otherwise.
Calling nagg_get_granules with geofiles_arg to not search for geo files or granules.
Calling nagg_select_granules with total_nproducts to get correct granule numbers selected.
Set geofilename=NULL for -g no.
nagg.h
Add total_nproducts parameter to select_granule function prototype.
nagg_write_granule.c
Error message improvements.
na...
This suppose set the version information in all related files.
This initial version only displays files that should be updated and how they
should be update. Real features will be added later.
Tested: koala
Updated for v1.0.1-beta1 release.
nagg.docx:
Added the new -g option description.
nagg.htm:
nagg.pdf:
Generated from nagg.docx.
NPP-Aggregation-Tool-Components.docx:
removed the trailing period from the command example.
NPP-Aggregation-Tool-Components.htm:
NPP-Aggregation-Tool-Components.pdf:
Generated from NPP-Aggregation-Tool-Components.docx.
testnagg.sh
Added tests for ig strict and -g yes using geofile with non-matching name.
test/testfiles/ICSST_npp...h5
test/testfiles/GCRIO_npp...h5
product and geo file with name that doesn't match the product file's attribute for testing -g strict and yes.
nagg_write_granules.c
nagg_get_granules.c
made small changes to address const and unsigned integer warnings.
Warning messages cleanup.
src/nagg_select_granules.c
Changed a temporary pointer from char* to const char* to eliminate
a warning. It expresses the intent of the pointer clearer.
src/nagg_product.c:
Added ULL quantifier to constants that are bigger than a 32bit int.
Added duration of each product to the product tables. Changed the
product tables a 1D array of structs.
src/nagg_main.c:
Cleaned up a #if not to show debug output.
src/nagg.h:
Removed old macros that access the columns of the old product tables.
Defined struct nppproduct_t for the new product tables.
Added iet_t get_product_duration_by_id which returns product duration.
src/nagg_options.c:
Removed print_product_lists from this source module. It is more
logical to put ...
nagg_get_granules.c
Differentiate behavior for getting geo granules from geolocation files when -g strict is specified. -g strict will now cause nagg to fail if the geolocation files in the N_GEO_Ref attributes of the product files don't have the exact names. Otherwise the exact names will be used if the file exists, but approximately matching names will be checked if the exact one is not found.
Tested jam and koala
nagg_write_granules.c
Added function update_string_attribute() to change the value of a string attribute.
Modified functions write_fillgr_time_attrs() and create_aggregate_dataset to use new function, writing time attributes of type string for missing granules and several first granule string attributes to the Beginning* attributes of the Aggr dataset.
Tested jam and koala.
nagg_get_granules.c
added comment identifying nagg_get_granules() function parameters for return values.
nagg_write_granules.c
Fixed bug with icc (parameter for H5LRget_region_info() was int, needed to be size_t)
Replaced product_name with dpid in product_info_t structure.
Internal index of separate geoproduct will be nproducts-1 (0 based index) with no need
for product id.
Product name will be obtained from granule when needed.
Tested on jam and koala with gcc and icc co...
Post release v1.0.0 release document updates.
configure.ac:
Changed to v1.0.1 under development. (It was not changed from 0.0.1 to
1.0.1 by mistake.)
configure:
Generated from configure.ac.
Tested: koala
Post release v1.0.0 release document updates.
doc/History:
Archived RELEASE.txt of v1.0.0.
src/nagg.h:
README:
Changed to v1.0.1 under development.
doc/RELEASE.txt:
Changed to v1.0.1 under development. Reset changes contents.
src/nagg_main.c:
should have sent number of sets of granules to start_write. Fixed.
src/nagg_write_granules.c
Added a debug statment only.
src/nagg_select_granules.c
Added iet2utc to convert IET to UTC format.
Added assignment to beginning_date, beginning_time, ending_time of
filled granules.
Tested: dove--all passed except when a file will contain leading fill granule.
Failure is probably in write_granules?
nagg_main.c:
Bug fix. It was using the wrong variable to call start_write. Should use
total_granules_file.
nagg_select_granules.c:
Added code to skip forward the next_slot_btime so that it will not produce
a file that contains only fill granules but no real ones.
nagg_write_granules.c
Fail if the number of granules written exceeds the number specified in start_write() or if less than the specified number have been written when end_write() is called.
Tested jam and koala.
nagg_get_granules.c
Fixed problem getting approximate match geo filename in local directory on koala.
nagg_write_granules.c
Corrected granule index tracking.
Tested jam and koala.
Added code to not making leading or trailing fill granules such that the first
and the last files maybe partial files.
Tested: passed but failed if some granules are missing in the middle.
nagg_get_granules.c
Added functions to get geofiles with names matching the name in the product file's N_GEO_Ref attribute except for the creation time, producer, and domain fields.
Tested jam and koala.
Initial implementation of creating fill granules to call write_granules().
Program is dying in write_granules(). Proceed to commit so that Larry may
debug the failure.
nagg.h:
added the Time_First_Ascend definition (not sure the value is correct).
nagg_posix.h:
added some more functions used.
nagg_select_granules.c
Initial implementation of init_fill_granules_array() and make_fill_granule()
to support the creation of fill granules when needed.
Tested in dove (linux)--failin...
nagg_write_granules.c
Discontinued aoutomatic writing of missing granules by the write_granules module. Missing granules are now to be sent explicitly from nagg_main/nagg_select_granules.
Refactoring:
Extracted code into new functions create_aggregate_dataset, copy_granule_hyperslabs, and several functions to assemble paths to groups and datasets.
Added more function headers.
Tested on jam and amani.
nagg_get_granules.c
Changed get_granules to not add our fill granules to the granule table.
nagg_write_granules.c
Write "Missing at delivery time" to N_Granule_Status when writing fill granules.
Add function headers and begin refactoring.
Tested on jam and koala.
Write correct number of granules to the AggregateNumberGranules attribute of the /DataProducts/..._Aggr dataset.
The index of the last granule was written, but since it was a 0 based index the value for AggregateNumberGranules is the index + 1.
Tested on jam and koala.