Author Commit Message Commit Date David Young 295295f957d Remove disused #ifdef QAK code. 09 Dec 2019 David Young 21e2c55c5a8 Be brief: don't cast the last parameter of H5Pset_file_space_strategy(), the
constant `1`, to `hsize_t`. 09 Dec 2019 David Young a56d19800cc Don't see a 1GB threshold for tracking free filespace, that workaround for VFD
SWMR was never 100% effective, and now that there is a delay line on filespace
frees, it is not necesesary. 09 Dec 2019 David Young ac286ab26bf Merge all of my changes from merge-back-to-feature-vfd_swmr-attempt-1,
including the merge of `hdffv/hdf5/develop`, back to the branch that Vailin and
I share.
Now I need to put this branch on a fork with a less confusing name than
vchoi_fork! 09 Dec 2019 Vailin Choi 9fb937b73d3 Fix the FSM bug when setting the FSM threshold to a non-default value.
Check for smaller or larger section size after merging and shrinking a section,
for this case is the section that is smaller than threshold (see H5MF_xfree() in H5MF.c).
It is possible for the section to be smaller after merging/shrinking (see H5MF__sect_large_shrink()
in H5MFsection.c). 02 Dec 2019 David Young f4506053379 Straggler from last commit: add test/vfd_swmr_common.c. 09 Dec 2019 David Young 901ca275a12 Make all VFD SWMR test writers wait for a signal before closing
their HDF5 file, and always send that signal after the readers
are finished. Carve out an exception, though, for the expand/shrink
test, where vfd_swmr_writer is used to initialize the file.
Move await_signal() to vfd_swmr_common.c for sharing with all of
the writers.
Add to vfd_swmr_writer a command-line option flag, -W, that stops
it from waiting for a signal before closing the HDF5 file and
quitting. While I'm here, rewrit... 09 Dec 2019 David Young 60c49e6f3eb Remove a calloc cast that was just for C++ compatibility and really uglied-up
the code. 09 Dec 2019 David Young c396d37945d Defer filespace frees performed by VFD SWMR writers so that raw-data space is
not reused prematurely. Probably should optimize this by freeing only the
freeing of raw-data regions is deferred. 06 Dec 2019 David Young 19577f797e8 I wish that I had known previously that developers were cheating the
cross-platform property-list test, because then I could have cheated, too, and
saved myself a lot of time. Regenerate and then copy the 64-bit, little-endian
version of the file over all other-bits and other-endian versions. I've filed
a ticket about this. 06 Dec 2019 David Young 0dbc26bec92 Use a for-loop instead of a while-loop to walk another linked list, taking care
of single-entry deletions. Will use LIST_FOREACH_SAFE() or a similar queue(3)
macro, eventually. 06 Dec 2019 David Young def41b41944 Use a for-loop instead of a while-loop to iterate a linked list in the face of
possible single-element deletions. Eventually I will use LIST_FOREACH_SAFE()
or some similar queue(3) macro. 06 Dec 2019 David Young c2514497530 Use a for-loop instead of a while-loop to search a linked list, and perform the
operation on a found item (if any) *outside* of the loop. Eventually this
for-loop will use a macro from queue(3). 06 Dec 2019 David Young 73076b3999e Rewrite a while-loop that walks a linked list as a for-loop. Eventually I will
replace the for-loop with a macro like LIST_FOREACH() from queue(3). 06 Dec 2019 David Young 80ea5c46218 Use a for-loop to walk a linked list. Eventually this will use a macro such as
LIST_FOREACH() from queue(3). 06 Dec 2019 David Young f5d68474fa3 Delete some excess whitespace and leave a comment to myself about why it's safe
to remove a page-table entry for freed file-space storage. NFCI. 06 Dec 2019 David Young 8746fb92554 Rename a variable, s/pbe_ptr/entry/, part 2. While I'm here, use a for-loop
instead of a while-loop to iterate over a linked-list of entries. Eventually I
will turn the for-loop to a use of LIST_FOREACH() or a similar macro from
queue(3). 06 Dec 2019 David Young 74cfb6cda2d Simplify a variable name, step 1. s/pbe_ptr/entry/ in some comments. 06 Dec 2019 David Young 8f0fd4f1073 Reduce parenthesization. NFCI. 06 Dec 2019 David Young bc936b2522a We never read through the metadata accumulator, so don't mention it in an error
message. 06 Dec 2019 David Young 8fbdb68133d Use the right format strings for uint32_t, uint64_t. 06 Dec 2019 David Young c5e5b2f0b86 Make a copy of NetBSD's <sys/queue.h> in src/bsdqueue.h. 05 Dec 2019 David Young 03205d1b9e9 Use struct assignment instead of memcpy. 05 Dec 2019 David Young 023e69990d8 Fix typo in an error message. 05 Dec 2019 David Young 5ec4a554b27 Delete gratuitous casts. 05 Dec 2019 David Young 21c3cb07229 Use proper format strings in some diagnostic printfs. NFCI. 05 Dec 2019 David Young 6efcb7d1d7d Assert that a raw-data page we are examining *does* intersect the interval
[addr, addr + size) that we are trying to read, replacing an assertion that did
not make any sense in context. I'm not sure why it took so long for the
nonsensical assertion to fire, but maybe it was because we didn't do any
multi-page raw-data reads through the page buffer, before? 04 Dec 2019 David Young 03eebd31186 Reduce code duplication in enc_dec_plist_cross_platform.c: extract a subroutine
that computes the name for a plist file, reads and decodes it. 04 Dec 2019 David Young 51250a4adb3 Extract a subroutine, vfd_swmr_pageno_to_mdf_idx_entry(), that performs the
binary search for the shadow-file entry corresponding to a page number.
Rewrite to avoid awkward casts between unsigned and signed integers. Use the
new routine in a couple of places. 04 Dec 2019 David Young e1e48314fe7 Mention the delay on freeing file space for VFD SWMR. 04 Dec 2019 David Young 55f52917ccd As an experiment, let's serialize property lists into a zeroed buffer. 02 Dec 2019 David Young 8eebac52728 Remove #if 0'd quick fix for the free-space management bug in
src/H5MF.c.
Also, squashed commit of the following:
commit adcf8a315e82c0848d126e7e46b662930c081896
Author: Vailin Choi <vchoi@jam.ad.hdfgroup.org>
Date: Mon Dec 2 11:07:25 2019 -0600
Fix the FSM bug when setting the FSM threshold to a non-default value.
Check for smaller or larger section size after merging and shrinking a section,
for this case is the section that is smaller than threshold (see H5MF_xfree() in H5... 02 Dec 2019 David Young 3b70a15c3de Regenerate 64-bit, little-endian test property lists. 02 Dec 2019 David Young 6181697bc04 Regenerate 32-bit little-endian test property lists. 02 Dec 2019 David Young 74dfbdecc85 Regenerate the 64-bit, big-endian property list test files. 27 Nov 2019 David Young bdbf7b79481 Regenerate plists for big-endian. 25 Nov 2019 David Young 3f5fb5fec46 If a compilation unit #include a header that defines a static inline function,
and that static inline function calls an external function, then even if you do
not use the inline function, the Solaris Studio compiler produces a reference
to that external. That behavior prevented H5make_libsettings from linking:
H5_nanosleep, used by the h5_retry_ functions, was not found. #including
H5retry_private.h only where it's needed fixes the issue. 25 Nov 2019 David Young a5ff057b1cb Quiet some warnings about change of sign changing values, signed v.
unsigned comparisons. 25 Nov 2019 David Young b8edead516e M Merge remote-tracking branch 'origin/feature/vfd_swmr' into merge-back-to-feature-vfd_swmr-attempt-1 25 Nov 2019 David Young 75aa099cab7 M Merge remote-tracking branch 'origin/feature/vfd_swmr' into merge-back-to-feature-vfd_swmr-attempt-1 25 Nov 2019 David Young 847cec21b44 We have to use H5VLobject() instead of H5Iobject(). Welcome to the New VOL
Order. :-/ 22 Nov 2019 David Young 291c28bec70 Straggler from last: adjust to the New H5F_shared_t Order, change some signed
integers back to unsigned. 21 Nov 2019 David Young 1174ef01bd4 M Merge remote-tracking branch 'origin/feature/vfd_swmr' into merge-back-to-feature-vfd_swmr-attempt-1 21 Nov 2019 David Young 4182a7126db Commit diagnostic changes to free-space management and my work in progress on
the VFD SWMR test-file generator so that Vailin can take a look at the bug I
found. 20 Nov 2019 David Young cbe7901ddae In the VFD SWMR expand/shrink test, have the reader trail behind the writer by
the maximum size of a change in dataset length so that it cannot jump in and
read a dataset *after* it's been extended but *before* the data is written.
With other changes (forthcoming), this prevents the expand/shrink test from
reading unexpected data values. 20 Nov 2019 David Young 346222a8760 Do not cork and uncork the metadata cache, that should not be necessary with
VFD SWMR. 19 Nov 2019 David Young 15f1cf64c81 Quiet the sparse writer: bracket the expected-to-fail H5Aexists_by_name() call
by H5Eget_auto/set_auto calls that temporarily disable the error-stack
printing. 19 Nov 2019 David Young 45d0761a3e9 Add a couple of debug echo(1)s and improve a comment. 19 Nov 2019 David Young 1e1a9c87636 Here is my work in progress on debugging the sparse reader/writer test. 14 Nov 2019 David Young 35dc70f1f1e Use h5_retry_init/_try to simplify this code a bit and shorten the staircase. 14 Nov 2019 ← Prev Next → require('plugin/commitgraph/network').applyCommits([{id: '295295f957d8e73b9c58bc351daa56af0803a031', href: '/users/dyoung/repos/vchoi_fork/commits/295295f957d8e73b9c58bc351daa56af0803a031',parents: [{ id: '21e2c55c5a8fd2f57895c81ba32a6db0b3fb2edb' }]},{id: '21e2c55c5a8fd2f57895c81ba32a6db0b3fb2edb', href: '/users/dyoung/repos/vchoi_fork/commits/21e2c55c5a8fd2f57895c81ba32a6db0b3fb2edb',parents: [{ id: 'a56d19800cc9b176742bf33c6dd06c16ffd0b428' }]},{id: 'a56d19800cc9b176742bf33c6dd06c16ffd0b428', href: '/users/dyoung/repos/vchoi_fork/commits/a56d19800cc9b176742bf33c6dd06c16ffd0b428',parents: [{ id: 'ac286ab26bf70a49e6d394d84afd770aec99310e' }]},{id: 'ac286ab26bf70a49e6d394d84afd770aec99310e', href: '/users/dyoung/repos/vchoi_fork/commits/ac286ab26bf70a49e6d394d84afd770aec99310e',parents: [{ id: '9fb937b73d37f057a29d6d340e4a20702e11e799' }]},{id: '9fb937b73d37f057a29d6d340e4a20702e11e799', href: '/users/dyoung/repos/vchoi_fork/commits/9fb937b73d37f057a29d6d340e4a20702e11e799',parents: [{ id: 'f4506053379ab8308b76064bd9fd93dbb35d3ac7' }]},{id: 'f4506053379ab8308b76064bd9fd93dbb35d3ac7', href: '/users/dyoung/repos/vchoi_fork/commits/f4506053379ab8308b76064bd9fd93dbb35d3ac7',labels: [{name: 'mar-merge-develop-to-swmr', type: 'BRANCH', href: '/users/dyoung/repos/vchoi_fork/browse?at=mar-merge-develop-to-swmr'},{name: 'merge-back-to-feature-vfd_swmr-attempt-1', type: 'BRANCH', href: '/users/dyoung/repos/vchoi_fork/browse?at=merge-back-to-feature-vfd_swmr-attempt-1'}],parents: [{ id: '901ca275a12f8bc207e482715f461a286bb7aa25' }]},{id: '901ca275a12f8bc207e482715f461a286bb7aa25', href: '/users/dyoung/repos/vchoi_fork/commits/901ca275a12f8bc207e482715f461a286bb7aa25',parents: [{ id: '60c49e6f3ebfc4cc276546fb946546de844f699e' }]},{id: '60c49e6f3ebfc4cc276546fb946546de844f699e', href: '/users/dyoung/repos/vchoi_fork/commits/60c49e6f3ebfc4cc276546fb946546de844f699e',parents: [{ id: 'c396d37945d3b5adff203512a442e9d102e68039' }]},{id: 'c396d37945d3b5adff203512a442e9d102e68039', href: '/users/dyoung/repos/vchoi_fork/commits/c396d37945d3b5adff203512a442e9d102e68039',parents: [{ id: '19577f797e81bbae324d15d86214af8781ae6c11' }]},{id: '19577f797e81bbae324d15d86214af8781ae6c11', href: '/users/dyoung/repos/vchoi_fork/commits/19577f797e81bbae324d15d86214af8781ae6c11',parents: [{ id: '0dbc26bec9267f026cae10a71ed98480f81952ae' }]},{id: '0dbc26bec9267f026cae10a71ed98480f81952ae', href: '/users/dyoung/repos/vchoi_fork/commits/0dbc26bec9267f026cae10a71ed98480f81952ae',parents: [{ id: 'def41b41944489e3b7ac2673f0c1412e8ebbf36e' }]},{id: 'def41b41944489e3b7ac2673f0c1412e8ebbf36e', href: '/users/dyoung/repos/vchoi_fork/commits/def41b41944489e3b7ac2673f0c1412e8ebbf36e',parents: [{ id: 'c2514497530574efc30206343959265a677f3bf2' }]},{id: 'c2514497530574efc30206343959265a677f3bf2', href: '/users/dyoung/repos/vchoi_fork/commits/c2514497530574efc30206343959265a677f3bf2',parents: [{ id: '73076b3999e67a203a6afacd8af2a5a0aec673b1' }]},{id: '73076b3999e67a203a6afacd8af2a5a0aec673b1', href: '/users/dyoung/repos/vchoi_fork/commits/73076b3999e67a203a6afacd8af2a5a0aec673b1',parents: [{ id: '80ea5c462180c245c40e6e63b8309b87648e8a28' }]},{id: '80ea5c462180c245c40e6e63b8309b87648e8a28', href: '/users/dyoung/repos/vchoi_fork/commits/80ea5c462180c245c40e6e63b8309b87648e8a28',parents: [{ id: 'f5d68474fa3ebe4cdc6e4041376e6beeff35ce45' }]},{id: 'f5d68474fa3ebe4cdc6e4041376e6beeff35ce45', href: '/users/dyoung/repos/vchoi_fork/commits/f5d68474fa3ebe4cdc6e4041376e6beeff35ce45',parents: [{ id: '8746fb92554b87e0205fc951b7872c086be7da7a' }]},{id: '8746fb92554b87e0205fc951b7872c086be7da7a', href: '/users/dyoung/repos/vchoi_fork/commits/8746fb92554b87e0205fc951b7872c086be7da7a',parents: [{ id: '74cfb6cda2d96a611ea81fbdec66e539df8d6e14' }]},{id: '74cfb6cda2d96a611ea81fbdec66e539df8d6e14', href: '/users/dyoung/repos/vchoi_fork/commits/74cfb6cda2d96a611ea81fbdec66e539df8d6e14',parents: [{ id: '8f0fd4f10732274fb2e5c08083403a671c73734c' }]},{id: '8f0fd4f10732274fb2e5c08083403a671c73734c', href: '/users/dyoung/repos/vchoi_fork/commits/8f0fd4f10732274fb2e5c08083403a671c73734c',parents: [{ id: 'bc936b2522a86de90f410a45763e3efdda25ac88' }]},{id: 'bc936b2522a86de90f410a45763e3efdda25ac88', href: '/users/dyoung/repos/vchoi_fork/commits/bc936b2522a86de90f410a45763e3efdda25ac88',parents: [{ id: '8fbdb68133dafcb4eb309113a0246af5724ca0a4' }]},{id: '8fbdb68133dafcb4eb309113a0246af5724ca0a4', href: '/users/dyoung/repos/vchoi_fork/commits/8fbdb68133dafcb4eb309113a0246af5724ca0a4',parents: [{ id: 'c5e5b2f0b863324ae2d0efb542244d3a2667be9c' }]},{id: 'c5e5b2f0b863324ae2d0efb542244d3a2667be9c', href: '/users/dyoung/repos/vchoi_fork/commits/c5e5b2f0b863324ae2d0efb542244d3a2667be9c',parents: [{ id: '03205d1b9e9dd3ee22f430f02da5331b018be914' }]},{id: '03205d1b9e9dd3ee22f430f02da5331b018be914', href: '/users/dyoung/repos/vchoi_fork/commits/03205d1b9e9dd3ee22f430f02da5331b018be914',parents: [{ id: '023e69990d81d6ec1d2de3d19537f2d8af79a40b' }]},{id: '023e69990d81d6ec1d2de3d19537f2d8af79a40b', href: '/users/dyoung/repos/vchoi_fork/commits/023e69990d81d6ec1d2de3d19537f2d8af79a40b',parents: [{ id: '5ec4a554b2728e1225bfe5e1e4f9aac6869d8136' }]},{id: '5ec4a554b2728e1225bfe5e1e4f9aac6869d8136', href: '/users/dyoung/repos/vchoi_fork/commits/5ec4a554b2728e1225bfe5e1e4f9aac6869d8136',parents: [{ id: '21c3cb07229a7a6820a85364b15a56fb6295dff7' }]},{id: '21c3cb07229a7a6820a85364b15a56fb6295dff7', href: '/users/dyoung/repos/vchoi_fork/commits/21c3cb07229a7a6820a85364b15a56fb6295dff7',parents: [{ id: '6efcb7d1d7d7d1b0f5041f648a5a2826afef5166' }]},{id: '6efcb7d1d7d7d1b0f5041f648a5a2826afef5166', href: '/users/dyoung/repos/vchoi_fork/commits/6efcb7d1d7d7d1b0f5041f648a5a2826afef5166',parents: [{ id: '03eebd31186e0ecc9944532a98e170df6ccd66d0' }]},{id: '03eebd31186e0ecc9944532a98e170df6ccd66d0', href: '/users/dyoung/repos/vchoi_fork/commits/03eebd31186e0ecc9944532a98e170df6ccd66d0',parents: [{ id: '51250a4adb38135144cf09b3f5d8b8173cf0d17c' }]},{id: '51250a4adb38135144cf09b3f5d8b8173cf0d17c', href: '/users/dyoung/repos/vchoi_fork/commits/51250a4adb38135144cf09b3f5d8b8173cf0d17c',parents: [{ id: 'e1e48314fe75b72755532dc99436661b8388388d' }]},{id: 'e1e48314fe75b72755532dc99436661b8388388d', href: '/users/dyoung/repos/vchoi_fork/commits/e1e48314fe75b72755532dc99436661b8388388d',parents: [{ id: '55f52917ccdfbe91c2b7326478b8b010742ccf68' }]},{id: '55f52917ccdfbe91c2b7326478b8b010742ccf68', href: '/users/dyoung/repos/vchoi_fork/commits/55f52917ccdfbe91c2b7326478b8b010742ccf68',parents: [{ id: '8eebac52728871b5133ebee5d6b724167da06365' }]},{id: '8eebac52728871b5133ebee5d6b724167da06365', href: '/users/dyoung/repos/vchoi_fork/commits/8eebac52728871b5133ebee5d6b724167da06365',parents: [{ id: '3b70a15c3deb35d5612540e24bca569d607aedb4' }]},{id: '3b70a15c3deb35d5612540e24bca569d607aedb4', href: '/users/dyoung/repos/vchoi_fork/commits/3b70a15c3deb35d5612540e24bca569d607aedb4',parents: [{ id: '6181697bc047e7cc522bf6e2fb52f5702944640e' }]},{id: '6181697bc047e7cc522bf6e2fb52f5702944640e', href: '/users/dyoung/repos/vchoi_fork/commits/6181697bc047e7cc522bf6e2fb52f5702944640e',parents: [{ id: '74dfbdecc8564933437acc840e416f2e60242929' }]},{id: '74dfbdecc8564933437acc840e416f2e60242929', href: '/users/dyoung/repos/vchoi_fork/commits/74dfbdecc8564933437acc840e416f2e60242929',parents: [{ id: 'bdbf7b7948129ae75a1c3f749d32c0951284454d' }]},{id: 'bdbf7b7948129ae75a1c3f749d32c0951284454d', href: '/users/dyoung/repos/vchoi_fork/commits/bdbf7b7948129ae75a1c3f749d32c0951284454d',parents: [{ id: '3f5fb5fec4606a662c4c75114d76b6185bfc9faa' }]},{id: '3f5fb5fec4606a662c4c75114d76b6185bfc9faa', href: '/users/dyoung/repos/vchoi_fork/commits/3f5fb5fec4606a662c4c75114d76b6185bfc9faa',parents: [{ id: 'a5ff057b1cbba470f22da10f52fbc9799e083045' }]},{id: 'a5ff057b1cbba470f22da10f52fbc9799e083045', href: '/users/dyoung/repos/vchoi_fork/commits/a5ff057b1cbba470f22da10f52fbc9799e083045',parents: [{ id: 'b8edead516e7fc7b500147e036920e1a05336b61' }]},{id: 'b8edead516e7fc7b500147e036920e1a05336b61', href: '/users/dyoung/repos/vchoi_fork/commits/b8edead516e7fc7b500147e036920e1a05336b61',parents: [{ id: '75aa099cab79747e21118b94157c19ff1730ec33' },{ id: '4d50f9a7a8737380b37b7cde751dbeae3b7c6b7c' }]},{id: '75aa099cab79747e21118b94157c19ff1730ec33', href: '/users/dyoung/repos/vchoi_fork/commits/75aa099cab79747e21118b94157c19ff1730ec33',parents: [{ id: '847cec21b44c551b462e02a4573a42b3cbbea8a1' },{ id: '0f9678b41526cf935506f11e389b5ccec3519f5b' }]},{id: '847cec21b44c551b462e02a4573a42b3cbbea8a1', href: '/users/dyoung/repos/vchoi_fork/commits/847cec21b44c551b462e02a4573a42b3cbbea8a1',parents: [{ id: '291c28bec70dce272c49c2614b227260f861c00b' }]},{id: '291c28bec70dce272c49c2614b227260f861c00b', href: '/users/dyoung/repos/vchoi_fork/commits/291c28bec70dce272c49c2614b227260f861c00b',parents: [{ id: '1174ef01bd400bf020074141259071a0d88ffab5' }]},{id: '1174ef01bd400bf020074141259071a0d88ffab5', href: '/users/dyoung/repos/vchoi_fork/commits/1174ef01bd400bf020074141259071a0d88ffab5',parents: [{ id: '4182a7126dbb992fc7e256d9611a997596ebb93c' },{ id: '12438c22b727f210c85dd74fb147f666c273a127' }]},{id: '4182a7126dbb992fc7e256d9611a997596ebb93c', href: '/users/dyoung/repos/vchoi_fork/commits/4182a7126dbb992fc7e256d9611a997596ebb93c',labels: [{name: 'vfd_swmr-merge-attempt-2', type: 'BRANCH', href: '/users/dyoung/repos/vchoi_fork/browse?at=vfd_swmr-merge-attempt-2'}],parents: [{ id: 'cbe7901ddae1220befdc97147740cfcbfde6d5ff' }]},{id: 'cbe7901ddae1220befdc97147740cfcbfde6d5ff', href: '/users/dyoung/repos/vchoi_fork/commits/cbe7901ddae1220befdc97147740cfcbfde6d5ff',parents: [{ id: '346222a8760c41cf05561287c02ef003a1f76510' }]},{id: '346222a8760c41cf05561287c02ef003a1f76510', href: '/users/dyoung/repos/vchoi_fork/commits/346222a8760c41cf05561287c02ef003a1f76510',labels: [{name: 'vfd_swmr-merge-attempt-2-wip', type: 'BRANCH', href: '/users/dyoung/repos/vchoi_fork/browse?at=vfd_swmr-merge-attempt-2-wip'}],parents: [{ id: '15f1cf64c813a54350a7cbf5af41c5a99de76ff2' }]},{id: '15f1cf64c813a54350a7cbf5af41c5a99de76ff2', href: '/users/dyoung/repos/vchoi_fork/commits/15f1cf64c813a54350a7cbf5af41c5a99de76ff2',parents: [{ id: '45d0761a3e9f8173c518c67f7fae45d4c1f20b7d' }]},{id: '45d0761a3e9f8173c518c67f7fae45d4c1f20b7d', href: '/users/dyoung/repos/vchoi_fork/commits/45d0761a3e9f8173c518c67f7fae45d4c1f20b7d',parents: [{ id: '1e1a9c8763681bd0f22979c477df1b0ee542fc02' }]},{id: '1e1a9c8763681bd0f22979c477df1b0ee542fc02', href: '/users/dyoung/repos/vchoi_fork/commits/1e1a9c8763681bd0f22979c477df1b0ee542fc02',parents: [{ id: '35dc70f1f1e02c861904842b2a9511913d31a598' }]},{id: '35dc70f1f1e02c861904842b2a9511913d31a598', href: '/users/dyoung/repos/vchoi_fork/commits/35dc70f1f1e02c861904842b2a9511913d31a598',parents: [{ id: '965068c81e0223332812710e7150fe28ee0f4477' }]}]);
