Author Commit Message Commit Date Gerd Heber 7ba4b88b1e4 [svn-r20915] Use HDstrncpy and HDstrncat! --gh 27 May 2011 Gerd Heber c6ca4d70c43 [svn-r20914] Use HDstrncat and HDstrncpy! --gh 27 May 2011 Allen Byrne 435cc985723 [svn-r20907] Original issue was #338.
Refactored code to clean up allocations consistantly, completely, check all returns, assign initialization values and handle errors.
Tested: local linux 25 May 2011 Neil Fortner 7e0e62434c6 [svn-r20883] Purpose: Fix coverity issue 585
Description:
Changed variable "c" in processStrData in h5import.c to an int, to match fgetc
return value, and removed call to feof, instead checking if c == EOF.
Tested: Fedora 20 May 2011 Vailin Choi f1d175ad0c7 [svn-r20882] Fixes for coverity:
1) bug #1679: remove dead code in test/mf.c
2) bug #1680: remove dead code in tools/lib/h5diff_dset.c
h5committested. 20 May 2011 Raymond Lu f5e10c05a8c [svn-r20881] Coverity #659 in Run 46: I changed the Line 442 where it tries to check whether FLAG_PRINTED is TRUE. But it had just been set to FALSE. I took out the condition check in the print statement.
Tested on jam.
20 May 2011 Allen Byrne 4fe27922364 [svn-r20880] Issue 192:
Create ret_val var set to -1. Add out label for failures to jump to, return ret_val at bottom.
Tested: local linux 20 May 2011 Allen Byrne 481ce4d8911 [svn-r20879] Issue 63: change check of return of H5Tget_nmembers to <=0. No need to go futher if call fails as well as empty.
Tested: local linux 20 May 2011 Allen Byrne fd7b171cf5c [svn-r20878] Issue 76: Check if H5Tget_nmembers(type) fails and simply return(FALSE). Also move printf to after check.
Tested: local linux 20 May 2011 Neil Fortner 9fd3d262bb2 [svn-r20877] Purpose: Fix coverity issue 1723
Description:
Modified test_generate in hl/test_image to close file "f" before exit, even if
an error occurs.
Tested: Fedora 20 May 2011 Larry Knox 9beccbeef6a [svn-r20837] Changed sprintf calls to snprintf with size 1 less than the allocated buffer to address coverity issue #967.
Tested on jam. 13 May 2011 Dana Robinson 743daf34582 [svn-r20836] Fixed coverity 585 by casting output of fgetc() to a char. 13 May 2011 Allen Byrne 900ceecfd27 [svn-r20835] Issue 1180:
Change to use strncpy - use base_len + 1 for line 156, use HDstrlen(path) + 1 for line 159 13 May 2011 Gerd Heber b0a58272f50 [svn-r20834] Use HDstrncpy and HDstrncat. --gh 13 May 2011 Dana Robinson adebb2f6a83 [svn-r20833] Fixed Coverity 667 and 668 with real integer overflow tests this time. 13 May 2011 Neil Fortner b1a73a63592 [svn-r20832] Purpose: Fix valgrind issues with hl/examples/ex_image2
Description:
Modified hl/examples/ex_image2 to free global "gbuf" before exit.
Tested: Fedora 13 May 2011 Elena Pourmal e409a7c45c9 [svn-r20831] Maintenance: Addressed CID 852
Replaced sprintf with snprintf
Platforms tested: jam with gfortran 13 May 2011 John Mainzer dfcf2e30f3f [svn-r20830]
resolved coverity issues 939, 940, 941, 944, and 947.
all were complaints about use of sprintf, and in all cases, the
buffers used were large enough for all eventualities.
Resolved issue by replacing calls to sprintf with calls
to snprintf. 13 May 2011 Allen Byrne 854afbd3d88 [svn-r20829] Issues 640 and 641:
Check return of H5Lget_val(print_udata->fid, path, targbuf, linfo->u.val_size + 1, H5P_DEFAULT) and if error set trgbuf[0] to 0.
check if H5Lunpack_elink_val(targbuf, linfo->u.val_size, NULL, &filename, &objname) was successful and allow print. Otherwise filename and objname are not created. (init those to NULL) 13 May 2011 Gerd Heber f399295fcbb [svn-r20828] Use HDstrncpy. --gh 13 May 2011 Gerd Heber 5dee221d54b [svn-r20827] Use HDstrncpy. --gh 13 May 2011 Neil Fortner 1eb11816917 [svn-r20826] Undo revision 20818, as that issue has already been fixed in the 1.8 branch and
trunk (but not coverity branch) 13 May 2011 Allen Byrne e2442e233b9 [svn-r20825] Issue 642: Added check for error and handler with print to stderr and exit. 13 May 2011 Elena Pourmal d2611bbcdc2 [svn-r20824] Maintenance: Bug fix: addressed CID 666.
Value stored at *expression_len should be used in the call to HD5packFstring to avoid
overflow (and unnecessary arithmetic calculation and casting) 13 May 2011 Larry Knox ee01868ec0b [svn-r20823] Changed HDstrcpy calls to HDstrncpy to address coverity issue #834 and return NULL from CommonFG::getComment on failure to address coverity issue #1720.
Tested on jam. 13 May 2011 Gerd Heber bf35dfb7077 [svn-r20822] Use HDstrncpy. --gh 13 May 2011 Gerd Heber 921ede744f3 [svn-r20821] Use HDstrncpy. --gh 13 May 2011 Elena Pourmal d62e4b933b9 [svn-r20820] Maintenance: Fixed the bug found by coverity CID 788
There were two problems with this function:
1) it tried to unnecessary free NULL pointer
2) it tried to allocate c_name buffer that is done by H5Pget_class_name
Fixed; tested on jam 13 May 2011 Allen Byrne 48023dafac3 [svn-r20819] Issue 80: change loop to use int as loop index. 13 May 2011 Neil Fortner 7ae54153ec2 [svn-r20818] Purpose: Fix valgrind issues with h5jam
Description:
Modified h5jam to free strings strdup'd in parse_command_line before exit. Note
that they may still not be freed in case of error, due to the widespread use of
exit().
Tested: Fedora 13 May 2011 Gerd Heber fd8d8491c92 [svn-r20817] Use HDstrncpy and HDstrncat. --gh 13 May 2011 Larry Knox 28fa75677b8 [svn-r20816] Replaced one last HDstrcat call with HDstrncat to resolve coverity issue 832.
Tested on jam. 13 May 2011 Gerd Heber b356e83f6bd [svn-r20815] Use HDstrncpy. --gh 13 May 2011 Allen Byrne 4ed1d03d249 [svn-r20814] Issue 69: Check return value and throw error if negative return. Also free datatype id on error 13 May 2011 Vailin Choi 765a19a9666 [svn-r20813] Remove the dead code as listed for coverity bug #1722. h5committested. 13 May 2011 Gerd Heber 45ab4103434 [svn-r20812] Use HDstrncpy. --gh 13 May 2011 Larry Knox 74040865de9 [svn-r20768] Switch to snprintf, HDstrncat, HDstrncpy to address coverity issue 832.
Tested jam. 06 May 2011 Dana Robinson 8fbbe511944 [svn-r20766] Fixed coverity bug 667
Pulled x * y * z multiply out of malloc operand into a separate n_elements variable to quiet integer overflow warning.
No actual integer overflow tests are performed since it's just a test program.
Passed on jam 06 May 2011 Dana Robinson 6c97c4f6178 [svn-r20765] Fixed coverity bug 668
Pulled x * y * z multiply out of malloc operand into a separate n_elements variable to quiet integer overflow warning.
No actual integer overflow tests are performed since it's just a test program but I did add a check that n_elements is >= 1.
I also changed an error condition from doing its own close and returning -1 to "goto out;" like the rest of the program.
Passed on jam 06 May 2011 Peter Cao ad7c44e890e [svn-r20764] fixed coverity issues:
69, 327, 614, 684, 685, 696, 697, 1681, 967, 826, 660, 80 06 May 2011 Neil Fortner 9bc8c4b95b7 [svn-r20763] Purpose: Fix valgrind issues with h5stat
Description:
Modified h5stat to free "iter" before exit, and free "hand" before exit if
parse_command_line exits directly.
Tested: Fedora 06 May 2011 Neil Fortner 20982e66e6a [svn-r20762] Purpose: Fix coverity issue 600
Description:
Add check for return value of H5O_close in H5Ocopy. Also cleaned up various
warnings.
Tested: Fedora 06 May 2011 Neil Fortner b4dfed57883 [svn-r20761] Purpose: Fix valgrind issues
Description:
Free image_data and data as appropriate in test_image.
Tested: Fedora 06 May 2011 Gerd Heber 17e93f2747a [svn-r20685] Use HDstrncpy. --gh 29 Apr 2011 Vailin Choi c6f087e3338 [svn-r20684] Fix for coverity bug #1721 which was due to the fix for coverity bug #943. 29 Apr 2011 Allen Byrne b61bb190657 [svn-r20683] Isues 1309-1333: Changed strcpy/strcat to strncpy/strncat with maximum size expected.
Tested: local linux 29 Apr 2011 Peter Cao f5d0c465110 [svn-r20682] fixed coverity:
76, 77, 635, 636, 1164, 1165, 1166, 1121, 1122, 1117, 1343 29 Apr 2011 Gerd Heber c52df6678df [svn-r20681] Use HDstrncat and HDstrncpy. --gh 29 Apr 2011 Gerd Heber 0c47ac924ad [svn-r20679] Use HDstrncpy. --gh 29 Apr 2011 John Mainzer c809b6f79a6 [svn-r20678]
Repaired coverity issue #598 -- failure to check return value from a
call to fstat(), or to tidy up in the event of failure.
Tested on wren 29 Apr 2011 ← Prev Next → require('plugin/commitgraph/network').applyCommits([{id: '7ba4b88b1e443fde47d8f1a665bacbc3fcf436d6', href: '/users/frank.willmore/repos/hdf5_der/commits/7ba4b88b1e443fde47d8f1a665bacbc3fcf436d6',parents: [{ id: 'c6ca4d70c43e308cc579d3ed81016002e8fae72d' }]},{id: 'c6ca4d70c43e308cc579d3ed81016002e8fae72d', href: '/users/frank.willmore/repos/hdf5_der/commits/c6ca4d70c43e308cc579d3ed81016002e8fae72d',parents: [{ id: '435cc985723e76fc3218048919a224fa51432392' }]},{id: '435cc985723e76fc3218048919a224fa51432392', href: '/users/frank.willmore/repos/hdf5_der/commits/435cc985723e76fc3218048919a224fa51432392',parents: [{ id: '7e0e62434c6080c9fd533b538162cd2720813dde' }]},{id: '7e0e62434c6080c9fd533b538162cd2720813dde', href: '/users/frank.willmore/repos/hdf5_der/commits/7e0e62434c6080c9fd533b538162cd2720813dde',parents: [{ id: 'f1d175ad0c797506f2b6c8b0d065a824aba91a83' }]},{id: 'f1d175ad0c797506f2b6c8b0d065a824aba91a83', href: '/users/frank.willmore/repos/hdf5_der/commits/f1d175ad0c797506f2b6c8b0d065a824aba91a83',parents: [{ id: 'f5e10c05a8c796c04f4430df25232de9875e921a' }]},{id: 'f5e10c05a8c796c04f4430df25232de9875e921a', href: '/users/frank.willmore/repos/hdf5_der/commits/f5e10c05a8c796c04f4430df25232de9875e921a',parents: [{ id: '4fe279223649335b1f59d3488bdbc255fcfc97e4' }]},{id: '4fe279223649335b1f59d3488bdbc255fcfc97e4', href: '/users/frank.willmore/repos/hdf5_der/commits/4fe279223649335b1f59d3488bdbc255fcfc97e4',parents: [{ id: '481ce4d8911b8236acdaddddc212c80ee7c60f19' }]},{id: '481ce4d8911b8236acdaddddc212c80ee7c60f19', href: '/users/frank.willmore/repos/hdf5_der/commits/481ce4d8911b8236acdaddddc212c80ee7c60f19',parents: [{ id: 'fd7b171cf5cdcd79b2c9dd584c286feeb3312f83' }]},{id: 'fd7b171cf5cdcd79b2c9dd584c286feeb3312f83', href: '/users/frank.willmore/repos/hdf5_der/commits/fd7b171cf5cdcd79b2c9dd584c286feeb3312f83',parents: [{ id: '9fd3d262bb2883957835556f37ef9b3a223f5a91' }]},{id: '9fd3d262bb2883957835556f37ef9b3a223f5a91', href: '/users/frank.willmore/repos/hdf5_der/commits/9fd3d262bb2883957835556f37ef9b3a223f5a91',parents: [{ id: '9beccbeef6ad4710027a86cfc2914ab4d6a1e307' }]},{id: '9beccbeef6ad4710027a86cfc2914ab4d6a1e307', href: '/users/frank.willmore/repos/hdf5_der/commits/9beccbeef6ad4710027a86cfc2914ab4d6a1e307',parents: [{ id: '743daf34582f1cfeef79a3a018eb6bd6074a7d03' }]},{id: '743daf34582f1cfeef79a3a018eb6bd6074a7d03', href: '/users/frank.willmore/repos/hdf5_der/commits/743daf34582f1cfeef79a3a018eb6bd6074a7d03',parents: [{ id: '900ceecfd27567e6d1151522b8805e10b21a22c7' }]},{id: '900ceecfd27567e6d1151522b8805e10b21a22c7', href: '/users/frank.willmore/repos/hdf5_der/commits/900ceecfd27567e6d1151522b8805e10b21a22c7',parents: [{ id: 'b0a58272f508a64d77c592aa38ccdeec38999b5a' }]},{id: 'b0a58272f508a64d77c592aa38ccdeec38999b5a', href: '/users/frank.willmore/repos/hdf5_der/commits/b0a58272f508a64d77c592aa38ccdeec38999b5a',parents: [{ id: 'adebb2f6a8316928a44234817fc740231871a0c6' }]},{id: 'adebb2f6a8316928a44234817fc740231871a0c6', href: '/users/frank.willmore/repos/hdf5_der/commits/adebb2f6a8316928a44234817fc740231871a0c6',parents: [{ id: 'b1a73a63592aeb3a483af2063563f3ebaccf03c8' }]},{id: 'b1a73a63592aeb3a483af2063563f3ebaccf03c8', href: '/users/frank.willmore/repos/hdf5_der/commits/b1a73a63592aeb3a483af2063563f3ebaccf03c8',parents: [{ id: 'e409a7c45c9f420af1738306913d5b7cd7999b19' }]},{id: 'e409a7c45c9f420af1738306913d5b7cd7999b19', href: '/users/frank.willmore/repos/hdf5_der/commits/e409a7c45c9f420af1738306913d5b7cd7999b19',parents: [{ id: 'dfcf2e30f3fd435c20830623f6f69be5623af142' }]},{id: 'dfcf2e30f3fd435c20830623f6f69be5623af142', href: '/users/frank.willmore/repos/hdf5_der/commits/dfcf2e30f3fd435c20830623f6f69be5623af142',parents: [{ id: '854afbd3d88e73b31a53c1b1a33d8b729200a4a9' }]},{id: '854afbd3d88e73b31a53c1b1a33d8b729200a4a9', href: '/users/frank.willmore/repos/hdf5_der/commits/854afbd3d88e73b31a53c1b1a33d8b729200a4a9',parents: [{ id: 'f399295fcbb7ed0fcab2f7331c93c85581dd57fa' }]},{id: 'f399295fcbb7ed0fcab2f7331c93c85581dd57fa', href: '/users/frank.willmore/repos/hdf5_der/commits/f399295fcbb7ed0fcab2f7331c93c85581dd57fa',parents: [{ id: '5dee221d54bb8296b6cf6845aea71c6c8877b523' }]},{id: '5dee221d54bb8296b6cf6845aea71c6c8877b523', href: '/users/frank.willmore/repos/hdf5_der/commits/5dee221d54bb8296b6cf6845aea71c6c8877b523',parents: [{ id: '1eb11816917863f164c9ebc84a093ed0821ff4a3' }]},{id: '1eb11816917863f164c9ebc84a093ed0821ff4a3', href: '/users/frank.willmore/repos/hdf5_der/commits/1eb11816917863f164c9ebc84a093ed0821ff4a3',parents: [{ id: 'e2442e233b9b087c29b57dc04da78a96e7ef6090' }]},{id: 'e2442e233b9b087c29b57dc04da78a96e7ef6090', href: '/users/frank.willmore/repos/hdf5_der/commits/e2442e233b9b087c29b57dc04da78a96e7ef6090',parents: [{ id: 'd2611bbcdc2d0cf010e1909a9773a1bb318d5fef' }]},{id: 'd2611bbcdc2d0cf010e1909a9773a1bb318d5fef', href: '/users/frank.willmore/repos/hdf5_der/commits/d2611bbcdc2d0cf010e1909a9773a1bb318d5fef',parents: [{ id: 'ee01868ec0b420696eca6b2083c079dc6e212100' }]},{id: 'ee01868ec0b420696eca6b2083c079dc6e212100', href: '/users/frank.willmore/repos/hdf5_der/commits/ee01868ec0b420696eca6b2083c079dc6e212100',parents: [{ id: 'bf35dfb7077eb5c378ba77214ba398ed321406bb' }]},{id: 'bf35dfb7077eb5c378ba77214ba398ed321406bb', href: '/users/frank.willmore/repos/hdf5_der/commits/bf35dfb7077eb5c378ba77214ba398ed321406bb',parents: [{ id: '921ede744f3327392ff73ad41322e5b49cdebb94' }]},{id: '921ede744f3327392ff73ad41322e5b49cdebb94', href: '/users/frank.willmore/repos/hdf5_der/commits/921ede744f3327392ff73ad41322e5b49cdebb94',parents: [{ id: 'd62e4b933b9b217063b22f1948324919f2b1450e' }]},{id: 'd62e4b933b9b217063b22f1948324919f2b1450e', href: '/users/frank.willmore/repos/hdf5_der/commits/d62e4b933b9b217063b22f1948324919f2b1450e',parents: [{ id: '48023dafac3046b226c08c5839cf237f68bee548' }]},{id: '48023dafac3046b226c08c5839cf237f68bee548', href: '/users/frank.willmore/repos/hdf5_der/commits/48023dafac3046b226c08c5839cf237f68bee548',parents: [{ id: '7ae54153ec2588a0bbe33da22a8845e3552efe1f' }]},{id: '7ae54153ec2588a0bbe33da22a8845e3552efe1f', href: '/users/frank.willmore/repos/hdf5_der/commits/7ae54153ec2588a0bbe33da22a8845e3552efe1f',parents: [{ id: 'fd8d8491c92591765ecbe631d216fa3922f34043' }]},{id: 'fd8d8491c92591765ecbe631d216fa3922f34043', href: '/users/frank.willmore/repos/hdf5_der/commits/fd8d8491c92591765ecbe631d216fa3922f34043',parents: [{ id: '28fa75677b8ce1c24c4d38a164cf1a85292d1a1f' }]},{id: '28fa75677b8ce1c24c4d38a164cf1a85292d1a1f', href: '/users/frank.willmore/repos/hdf5_der/commits/28fa75677b8ce1c24c4d38a164cf1a85292d1a1f',parents: [{ id: 'b356e83f6bd492cd3c27c5714790f63c25bf9d31' }]},{id: 'b356e83f6bd492cd3c27c5714790f63c25bf9d31', href: '/users/frank.willmore/repos/hdf5_der/commits/b356e83f6bd492cd3c27c5714790f63c25bf9d31',parents: [{ id: '4ed1d03d249f514d982b1dfe3d42edd6ff051e99' }]},{id: '4ed1d03d249f514d982b1dfe3d42edd6ff051e99', href: '/users/frank.willmore/repos/hdf5_der/commits/4ed1d03d249f514d982b1dfe3d42edd6ff051e99',parents: [{ id: '765a19a9666ad120783788658379acc155598edc' }]},{id: '765a19a9666ad120783788658379acc155598edc', href: '/users/frank.willmore/repos/hdf5_der/commits/765a19a9666ad120783788658379acc155598edc',parents: [{ id: '45ab41034349a658b3888064a5a51bc6c928099d' }]},{id: '45ab41034349a658b3888064a5a51bc6c928099d', href: '/users/frank.willmore/repos/hdf5_der/commits/45ab41034349a658b3888064a5a51bc6c928099d',parents: [{ id: '74040865de9c1995f11beb58dd144a79946a544a' }]},{id: '74040865de9c1995f11beb58dd144a79946a544a', href: '/users/frank.willmore/repos/hdf5_der/commits/74040865de9c1995f11beb58dd144a79946a544a',parents: [{ id: '8fbbe51194417de97986b205e646ccd6bb5ff67d' }]},{id: '8fbbe51194417de97986b205e646ccd6bb5ff67d', href: '/users/frank.willmore/repos/hdf5_der/commits/8fbbe51194417de97986b205e646ccd6bb5ff67d',parents: [{ id: '6c97c4f617814d6799db3e36a37f28f722a5a788' }]},{id: '6c97c4f617814d6799db3e36a37f28f722a5a788', href: '/users/frank.willmore/repos/hdf5_der/commits/6c97c4f617814d6799db3e36a37f28f722a5a788',parents: [{ id: 'ad7c44e890e8016e708b684b4e214f987f89ccc3' }]},{id: 'ad7c44e890e8016e708b684b4e214f987f89ccc3', href: '/users/frank.willmore/repos/hdf5_der/commits/ad7c44e890e8016e708b684b4e214f987f89ccc3',parents: [{ id: '9bc8c4b95b77c735db1020276f4f9041c0c19ccb' }]},{id: '9bc8c4b95b77c735db1020276f4f9041c0c19ccb', href: '/users/frank.willmore/repos/hdf5_der/commits/9bc8c4b95b77c735db1020276f4f9041c0c19ccb',parents: [{ id: '20982e66e6a6b548f392fcb22fb25383c810635f' }]},{id: '20982e66e6a6b548f392fcb22fb25383c810635f', href: '/users/frank.willmore/repos/hdf5_der/commits/20982e66e6a6b548f392fcb22fb25383c810635f',parents: [{ id: 'b4dfed57883a4572878412bedfdae8347a331b3d' }]},{id: 'b4dfed57883a4572878412bedfdae8347a331b3d', href: '/users/frank.willmore/repos/hdf5_der/commits/b4dfed57883a4572878412bedfdae8347a331b3d',parents: [{ id: '17e93f2747a903b3c2821a73eb1ba50069d10175' }]},{id: '17e93f2747a903b3c2821a73eb1ba50069d10175', href: '/users/frank.willmore/repos/hdf5_der/commits/17e93f2747a903b3c2821a73eb1ba50069d10175',parents: [{ id: 'c6f087e33388b85fa555bf84d3108e023ab1c5d6' }]},{id: 'c6f087e33388b85fa555bf84d3108e023ab1c5d6', href: '/users/frank.willmore/repos/hdf5_der/commits/c6f087e33388b85fa555bf84d3108e023ab1c5d6',parents: [{ id: 'b61bb19065746a05a8ae1cc1307fdf53c7334a10' }]},{id: 'b61bb19065746a05a8ae1cc1307fdf53c7334a10', href: '/users/frank.willmore/repos/hdf5_der/commits/b61bb19065746a05a8ae1cc1307fdf53c7334a10',parents: [{ id: 'f5d0c4651104967d7e954d2b12e11e615565f1ed' }]},{id: 'f5d0c4651104967d7e954d2b12e11e615565f1ed', href: '/users/frank.willmore/repos/hdf5_der/commits/f5d0c4651104967d7e954d2b12e11e615565f1ed',parents: [{ id: 'c52df6678df01996eef363ac1a16909037495efd' }]},{id: 'c52df6678df01996eef363ac1a16909037495efd', href: '/users/frank.willmore/repos/hdf5_der/commits/c52df6678df01996eef363ac1a16909037495efd',parents: [{ id: '0c47ac924add48447017744078da44f76c22ab8f' }]},{id: '0c47ac924add48447017744078da44f76c22ab8f', href: '/users/frank.willmore/repos/hdf5_der/commits/0c47ac924add48447017744078da44f76c22ab8f',parents: [{ id: 'c809b6f79a6313c9c251acb82bf20edff0daa4d0' }]},{id: 'c809b6f79a6313c9c251acb82bf20edff0daa4d0', href: '/users/frank.willmore/repos/hdf5_der/commits/c809b6f79a6313c9c251acb82bf20edff0daa4d0',parents: [{ id: '36bb80baebd414c86e3a8530bdbfa0d6880b26e8' }]}]);
