Author Commit Message Commit Date Vailin Choi 36bb80baebd [svn-r20675] Fix for coverity #1714 due to the fix for #810.
Use HDfree() instead of H5MM_xfree(). 29 Apr 2011 Allen Byrne 68730696767 [svn-r20668] Add test_configuration setting 28 Apr 2011 Allen Byrne 3444fc118a5 [svn-r20664] Remove extraneous memcheck parameters 28 Apr 2011 Gerd Heber 02614dec682 [svn-r20614] Use HDsnprintf. --gh 22 Apr 2011 Larry Knox b470fed3b54 [svn-r20612] Changed string functions to versions with string length to fix coverity issues 922, 942 and 943.
Teted on jam. 22 Apr 2011 Gerd Heber bcda15ae15c [svn-r20611] Use HDstrncpy. --gh 22 Apr 2011 Gerd Heber 8ce468af77c [svn-r20609] Use HDstrncpy and HDstrncat. --gh 22 Apr 2011 Larry Knox 99b31e64185 [svn-r20607] Changed string function calls to use versions that specify the string length to fix coverity issues 832 and 839.
Tested on jam. 22 Apr 2011 Neil Fortner 7a8ac70ecb6 [svn-r20606] Purpose: Fix coverity issue 807
Description: Modified long_compact in stab.c to keep track of whether objname is
allocated by setting it to NULL when it is not. Added code to free objname on
error if it is not NULL.
Tested: Fedora 22 Apr 2011 Gerd Heber fde41d30512 [svn-r20605] Use HDstrncpy and HDstrncat. --gh 22 Apr 2011 Gerd Heber 3e1c77db9fd [svn-r20604] Use HDstrncpy. --gh 22 Apr 2011 Neil Fortner ea7e3799c51 [svn-r20603] Purpose: Fix coverity issues 808-809
Description: Modified test_core in vfd.c to check the returns from malloc, and
keep track of whether points and check are allocated by setting them to NULL
when they are not. Added code to free points and check on error if they are
not NULL. Also fixed unrelated warnings in vfd.c.
Tested: Fedora 22 Apr 2011 Gerd Heber 05a07a1dbf3 [svn-r20602] Use HDsnprintf and HDstrncat --gh 22 Apr 2011 Neil Fortner 1422f5bc125 [svn-r20601] Purpose: Fix coverity issues 1703-1705
Description: Modified the cleanup code in test_free in accum.c to reset
allocated buffers to NULL after they are freed, and modified the error cleanup
code to check if these buffers are NULL before freeing them. Also fixed some
unrelated warnings in accum.c.
Tested: Fedora 22 Apr 2011 Neil Fortner 886f9727323 [svn-r20528] Purpose: Fix coverity issue 1372
Description: Rewrite file open secition of H5FD_stdio_open to avoid TOCTUO
condition. No longer calls access, and uses a tentative open in "rb" or "rb+"
mode to check for existence of the file.
Tested: Fedora 15 Apr 2011 Gerd Heber 8ff955cdf6e [svn-r20524] Check H5Z_SZIP->encoder_present < 1 assuming 0 represents absence.
--gh 15 Apr 2011 Peter Cao a5fbfbaa866 [svn-r20523] fixed coverity issues 68, 1120, 1116i 15 Apr 2011 John Mainzer 94a04f0a584 [svn-r20522] Addressed coverity issues 930-933, 850, 836, 835, 1307. All minor
potential buffer overwrite bugs, or coverity errors. Fixed by replacing
strcpy and sprintf with strncpy and snprintf.
Tested on wren. 15 Apr 2011 Gerd Heber c89d53ba806 [svn-r20516] Added else branch to the if (ret_value < 0) check. --gh 15 Apr 2011 Gerd Heber 966e33e61fa [svn-r20514] Initialize h5fid = -1 and predicate HDclose call on h5fid != -1
--gh 15 Apr 2011 Gerd Heber 2ece1fae1fb [svn-r20512] Initialize ifid = -1 and predicate HDclose call on ifid != -1
--gh 15 Apr 2011 Neil Fortner 9b3da7dd207 [svn-r20511] Purpose: Fix coverity issue 1715
Description: Free "file" and nested data on failure in H5FD_core_open.
Tested: Fedora 15 Apr 2011 Gerd Heber 494dc89b76e [svn-r20510] Initialize ufid = -1 and predicate HDclose call on ufid != -1
--gh 15 Apr 2011 Allen Byrne 00bdb46f5a0 [svn-r20457] Coverity issue 691: return of H5duo could be negative. Fixed by using STDOUT_FILENO and redesign parse_command_line and main to cleanup file allocations. The output_file var is null when using stdout. In cleanup do not close output_file if NULL.
Tested: local linux 08 Apr 2011 Peter Cao b81336db9ef [svn-r20456] fixed coverity 678, 679 08 Apr 2011 Neil Fortner f78da50bec6 [svn-r20455] Purpose: Cleanup fix for coverity issue 816
Description: Removed redundant check for "fa" in H5FD_core_open.
Tested: Fedora 08 Apr 2011 Neil Fortner c74a8ad3ddf [svn-r20454] Purpose: Fix coverity issue 816
Description: Modified various file drivers to always check the return value from
H5P_get_driver_info.
Tested: Fedora 08 Apr 2011 Peter Cao 61350ed450a [svn-r20451] Fixed coverity 810 08 Apr 2011 Peter Cao b7a29a17145 [svn-r20450] fixed coverity 813 08 Apr 2011 Neil Fortner 1e5622ce2e6 [svn-r20449] Purpose: Fix coverity issue 82
Description: Modified H5E_walk2_cb to check return value of H5I_object_verify.
Tested: Fedora 08 Apr 2011 Jonathan Kim 607c10e607c [svn-r20414] This is related to the previous checkin r20399. There were incorrect updates which caused incorrect behavior when no file was given. Also possible segfault when handling hyperslab options. Simplify the code changes. 04 Apr 2011 Larry Knox 3e193cb378f [svn-r20402] Added #includes for h5tools.y or h5tools_utils.h as required to remedy implicit function declarations which caused compiler warnings and coverity issues 703-4 and 708-11.
Tested on jam. 01 Apr 2011 Gerd Heber f0c6b9a212f [svn-r20401] Added free(src_sizes) and free(src_offset). --gh 01 Apr 2011 Neil Fortner 27e145fb4bc [svn-r20400] Purpose: Fix coverity issue 592
Description: Added void cast to call to H5F_sfile_assert_num() in
H5F_term)interface(). There is no need to check the return value of this
function in general, and there would be nothing to do even if it did fail.
Tested: Fedora 01 Apr 2011 Allen Byrne 3bacf1a72b7 [svn-r20399] Change parse_command_line to free hand structure on error and only "leave()" at end of main.
Tested by: JKM 01 Apr 2011 Gerd Heber e0229ea4813 [svn-r20398] Added free(src_offset). --gh 01 Apr 2011 Gerd Heber c7ac1ea7472 [svn-r20397] Added free(src_sizes) --gh 01 Apr 2011 Gerd Heber 26234fc6541 [svn-r20396] Should be H5MM_calloc(count * sizeof(void*)). Fixed. --gh 01 Apr 2011 Gerd Heber 664d90224a4 [svn-r20395] Should be H5MM_calloc(count * sizeof(void*)). Fixed --gh 01 Apr 2011 Neil Fortner 66a500271cf [svn-r20394] Purpose: Fix coverity issues 1674 and 1675
Description: Modified H5Epush2() and H5E_printf_stack() to keep track of whether
va_start() has been called, and to call va_end() at the end if so.
Tested: Fedora 01 Apr 2011 Gerd Heber 69009f5c674 [svn-r20393] Move initialization ocrt_info.new_obj = NULL; before FUNC_ENTER_NOAPI -- gh 01 Apr 2011 Neil Fortner 39ef9f07c6b [svn-r20392] Purpose: Fix coverity issues 1677 and 1678
Description: Added return value checking for 4 funciton calls in
H5tools_get_symlink_info().
Tested: Fedora 01 Apr 2011 Allen Byrne 12a4d5640a9 [svn-r20360] Remove testfiles not in coverity branch 28 Mar 2011 Allen Byrne 534b3460cbd [svn-r20356] Remove executable file 28 Mar 2011 Allen Byrne 44c2c55860d [svn-r20352] Update Valgrind ignore list 26 Mar 2011 Larry Knox 7151d3ef511 [svn-r20348] Addressed Coverity issue 705 - added prototype for resize_configs_are_equal to cache_common.h. 25 Mar 2011 Neil Fortner c7b655e119f [svn-r20347] Purpose: Fix memory leak in overhead.c
Description: Fixed leak in test() in overhead.c where array "had" was never
freed.
Tested: Fedora (valgrind) 25 Mar 2011 Allen Byrne bd683abe175 [svn-r20346] Merge cmake changes from 1.8 to coverity to correct valgrind issues already fixed in trunk/branch 25 Mar 2011 Neil Fortner 6f3c8cad180 [svn-r20345] Purpose: Fix valgrind issues in tvlstr.cpp and H5CommonFG.cpp
Description: Fixed bug in test_vlstring_dataset() where a c string was created
and used without a null terminator, potentially causing memory errors. Fixed
leak in H5::CommonFG::getComment() where a temporary variable would not be freed
in case of error.
Tested: Fedora 25 Mar 2011 Gerd Heber 523725e620b [svn-r20344] Added initialization udata.path = NULL; to prevent uninitialized used after done: label 25 Mar 2011 ← Prev Next → require('plugin/commitgraph/network').applyCommits([{id: '36bb80baebd414c86e3a8530bdbfa0d6880b26e8', href: '/users/frank.willmore/repos/hdf5_der/commits/36bb80baebd414c86e3a8530bdbfa0d6880b26e8',parents: [{ id: '68730696767ee65c8a4f2bbe187b2577fc3b895f' }]},{id: '68730696767ee65c8a4f2bbe187b2577fc3b895f', href: '/users/frank.willmore/repos/hdf5_der/commits/68730696767ee65c8a4f2bbe187b2577fc3b895f',parents: [{ id: '3444fc118a549499d4eafdfd10293f2d6b585ecc' }]},{id: '3444fc118a549499d4eafdfd10293f2d6b585ecc', href: '/users/frank.willmore/repos/hdf5_der/commits/3444fc118a549499d4eafdfd10293f2d6b585ecc',parents: [{ id: '02614dec682ae5ff73cf772c2c811eb5e4864727' }]},{id: '02614dec682ae5ff73cf772c2c811eb5e4864727', href: '/users/frank.willmore/repos/hdf5_der/commits/02614dec682ae5ff73cf772c2c811eb5e4864727',parents: [{ id: 'b470fed3b5417c984fd633d46b893d4d8173a387' }]},{id: 'b470fed3b5417c984fd633d46b893d4d8173a387', href: '/users/frank.willmore/repos/hdf5_der/commits/b470fed3b5417c984fd633d46b893d4d8173a387',parents: [{ id: 'bcda15ae15c121fc3973a13bb2b046dabde1e311' }]},{id: 'bcda15ae15c121fc3973a13bb2b046dabde1e311', href: '/users/frank.willmore/repos/hdf5_der/commits/bcda15ae15c121fc3973a13bb2b046dabde1e311',parents: [{ id: '8ce468af77c51bfe4543305d36eeb838c7255886' }]},{id: '8ce468af77c51bfe4543305d36eeb838c7255886', href: '/users/frank.willmore/repos/hdf5_der/commits/8ce468af77c51bfe4543305d36eeb838c7255886',parents: [{ id: '99b31e64185d2f0e6c9c6b949f5e5da8c9b91ad4' }]},{id: '99b31e64185d2f0e6c9c6b949f5e5da8c9b91ad4', href: '/users/frank.willmore/repos/hdf5_der/commits/99b31e64185d2f0e6c9c6b949f5e5da8c9b91ad4',parents: [{ id: '7a8ac70ecb659254f12de859794c78a6d00a39f3' }]},{id: '7a8ac70ecb659254f12de859794c78a6d00a39f3', href: '/users/frank.willmore/repos/hdf5_der/commits/7a8ac70ecb659254f12de859794c78a6d00a39f3',parents: [{ id: 'fde41d3051283077f744e0d1577b57e8d2fe2b13' }]},{id: 'fde41d3051283077f744e0d1577b57e8d2fe2b13', href: '/users/frank.willmore/repos/hdf5_der/commits/fde41d3051283077f744e0d1577b57e8d2fe2b13',parents: [{ id: '3e1c77db9fd16a8f9fe3bb642b629e12b549ec5c' }]},{id: '3e1c77db9fd16a8f9fe3bb642b629e12b549ec5c', href: '/users/frank.willmore/repos/hdf5_der/commits/3e1c77db9fd16a8f9fe3bb642b629e12b549ec5c',parents: [{ id: 'ea7e3799c511d674184fb29b814a2c8ee0b365fa' }]},{id: 'ea7e3799c511d674184fb29b814a2c8ee0b365fa', href: '/users/frank.willmore/repos/hdf5_der/commits/ea7e3799c511d674184fb29b814a2c8ee0b365fa',parents: [{ id: '05a07a1dbf349a835d6a45754cb1cb17bd5af91f' }]},{id: '05a07a1dbf349a835d6a45754cb1cb17bd5af91f', href: '/users/frank.willmore/repos/hdf5_der/commits/05a07a1dbf349a835d6a45754cb1cb17bd5af91f',parents: [{ id: '1422f5bc125eecdc79ac528e63a07dbe83e0540a' }]},{id: '1422f5bc125eecdc79ac528e63a07dbe83e0540a', href: '/users/frank.willmore/repos/hdf5_der/commits/1422f5bc125eecdc79ac528e63a07dbe83e0540a',parents: [{ id: '886f9727323bcc9fa22bbe01331f4eec7b471323' }]},{id: '886f9727323bcc9fa22bbe01331f4eec7b471323', href: '/users/frank.willmore/repos/hdf5_der/commits/886f9727323bcc9fa22bbe01331f4eec7b471323',parents: [{ id: '8ff955cdf6e39040e5f8ab11ec6de48a583c42a6' }]},{id: '8ff955cdf6e39040e5f8ab11ec6de48a583c42a6', href: '/users/frank.willmore/repos/hdf5_der/commits/8ff955cdf6e39040e5f8ab11ec6de48a583c42a6',parents: [{ id: 'a5fbfbaa8664b9024a8bf295ef7c5e9d3ff5616e' }]},{id: 'a5fbfbaa8664b9024a8bf295ef7c5e9d3ff5616e', href: '/users/frank.willmore/repos/hdf5_der/commits/a5fbfbaa8664b9024a8bf295ef7c5e9d3ff5616e',parents: [{ id: '94a04f0a584da97c20110b1251a93c941f463fee' }]},{id: '94a04f0a584da97c20110b1251a93c941f463fee', href: '/users/frank.willmore/repos/hdf5_der/commits/94a04f0a584da97c20110b1251a93c941f463fee',parents: [{ id: 'c89d53ba806e8fa2314e1cff74fa88138b0347d9' }]},{id: 'c89d53ba806e8fa2314e1cff74fa88138b0347d9', href: '/users/frank.willmore/repos/hdf5_der/commits/c89d53ba806e8fa2314e1cff74fa88138b0347d9',parents: [{ id: '966e33e61fab85369ee66b998a759c8b509820a5' }]},{id: '966e33e61fab85369ee66b998a759c8b509820a5', href: '/users/frank.willmore/repos/hdf5_der/commits/966e33e61fab85369ee66b998a759c8b509820a5',parents: [{ id: '2ece1fae1fbedc0187bfbb5ae3718828df40b488' }]},{id: '2ece1fae1fbedc0187bfbb5ae3718828df40b488', href: '/users/frank.willmore/repos/hdf5_der/commits/2ece1fae1fbedc0187bfbb5ae3718828df40b488',parents: [{ id: '9b3da7dd207789f2c604da7c99f3ae276a764780' }]},{id: '9b3da7dd207789f2c604da7c99f3ae276a764780', href: '/users/frank.willmore/repos/hdf5_der/commits/9b3da7dd207789f2c604da7c99f3ae276a764780',parents: [{ id: '494dc89b76ef5bb144167e3c00e9ce6ee83a9405' }]},{id: '494dc89b76ef5bb144167e3c00e9ce6ee83a9405', href: '/users/frank.willmore/repos/hdf5_der/commits/494dc89b76ef5bb144167e3c00e9ce6ee83a9405',parents: [{ id: '00bdb46f5a0a9a521991a37dd3e2e0e1fca89ba7' }]},{id: '00bdb46f5a0a9a521991a37dd3e2e0e1fca89ba7', href: '/users/frank.willmore/repos/hdf5_der/commits/00bdb46f5a0a9a521991a37dd3e2e0e1fca89ba7',parents: [{ id: 'b81336db9efab32c6c936bd987170d9611ebe12c' }]},{id: 'b81336db9efab32c6c936bd987170d9611ebe12c', href: '/users/frank.willmore/repos/hdf5_der/commits/b81336db9efab32c6c936bd987170d9611ebe12c',parents: [{ id: 'f78da50bec6294b0517b9a3ba6d2c7f81e5ea0a3' }]},{id: 'f78da50bec6294b0517b9a3ba6d2c7f81e5ea0a3', href: '/users/frank.willmore/repos/hdf5_der/commits/f78da50bec6294b0517b9a3ba6d2c7f81e5ea0a3',parents: [{ id: 'c74a8ad3ddf56efa07e837800719e2d9f134f766' }]},{id: 'c74a8ad3ddf56efa07e837800719e2d9f134f766', href: '/users/frank.willmore/repos/hdf5_der/commits/c74a8ad3ddf56efa07e837800719e2d9f134f766',parents: [{ id: '61350ed450a75e325a2b4bdae7118a4edead5722' }]},{id: '61350ed450a75e325a2b4bdae7118a4edead5722', href: '/users/frank.willmore/repos/hdf5_der/commits/61350ed450a75e325a2b4bdae7118a4edead5722',parents: [{ id: 'b7a29a171451a3e83142d021814e1f30e1a5541b' }]},{id: 'b7a29a171451a3e83142d021814e1f30e1a5541b', href: '/users/frank.willmore/repos/hdf5_der/commits/b7a29a171451a3e83142d021814e1f30e1a5541b',parents: [{ id: '1e5622ce2e63072ec527343f3436ccf580f31b49' }]},{id: '1e5622ce2e63072ec527343f3436ccf580f31b49', href: '/users/frank.willmore/repos/hdf5_der/commits/1e5622ce2e63072ec527343f3436ccf580f31b49',parents: [{ id: '607c10e607ce4958634ba7d40ca562c6db56a63d' }]},{id: '607c10e607ce4958634ba7d40ca562c6db56a63d', href: '/users/frank.willmore/repos/hdf5_der/commits/607c10e607ce4958634ba7d40ca562c6db56a63d',parents: [{ id: '3e193cb378f0095691b9a8a10b93ab8f0611e66d' }]},{id: '3e193cb378f0095691b9a8a10b93ab8f0611e66d', href: '/users/frank.willmore/repos/hdf5_der/commits/3e193cb378f0095691b9a8a10b93ab8f0611e66d',parents: [{ id: 'f0c6b9a212f4ab8b9bbbbee044d1e70109a99e70' }]},{id: 'f0c6b9a212f4ab8b9bbbbee044d1e70109a99e70', href: '/users/frank.willmore/repos/hdf5_der/commits/f0c6b9a212f4ab8b9bbbbee044d1e70109a99e70',parents: [{ id: '27e145fb4bc1e76f619da694fff6f7722a03abc1' }]},{id: '27e145fb4bc1e76f619da694fff6f7722a03abc1', href: '/users/frank.willmore/repos/hdf5_der/commits/27e145fb4bc1e76f619da694fff6f7722a03abc1',parents: [{ id: '3bacf1a72b74f8e92c30b993bbc49bb80c972e79' }]},{id: '3bacf1a72b74f8e92c30b993bbc49bb80c972e79', href: '/users/frank.willmore/repos/hdf5_der/commits/3bacf1a72b74f8e92c30b993bbc49bb80c972e79',parents: [{ id: 'e0229ea4813129f7d948e99375ddd643536f1ebf' }]},{id: 'e0229ea4813129f7d948e99375ddd643536f1ebf', href: '/users/frank.willmore/repos/hdf5_der/commits/e0229ea4813129f7d948e99375ddd643536f1ebf',parents: [{ id: 'c7ac1ea7472fa260c9765fa5818e0eb4840789cf' }]},{id: 'c7ac1ea7472fa260c9765fa5818e0eb4840789cf', href: '/users/frank.willmore/repos/hdf5_der/commits/c7ac1ea7472fa260c9765fa5818e0eb4840789cf',parents: [{ id: '26234fc65415fa2226c4f9bfd797503222274312' }]},{id: '26234fc65415fa2226c4f9bfd797503222274312', href: '/users/frank.willmore/repos/hdf5_der/commits/26234fc65415fa2226c4f9bfd797503222274312',parents: [{ id: '664d90224a47f78af1f7372921f6502155fec78b' }]},{id: '664d90224a47f78af1f7372921f6502155fec78b', href: '/users/frank.willmore/repos/hdf5_der/commits/664d90224a47f78af1f7372921f6502155fec78b',parents: [{ id: '66a500271cf55f10670d108f9f04976fa2da97af' }]},{id: '66a500271cf55f10670d108f9f04976fa2da97af', href: '/users/frank.willmore/repos/hdf5_der/commits/66a500271cf55f10670d108f9f04976fa2da97af',parents: [{ id: '69009f5c6749d4c8ee16383c3285ce80460f6a18' }]},{id: '69009f5c6749d4c8ee16383c3285ce80460f6a18', href: '/users/frank.willmore/repos/hdf5_der/commits/69009f5c6749d4c8ee16383c3285ce80460f6a18',parents: [{ id: '39ef9f07c6bebbf060b45bd052abac8fda24f67f' }]},{id: '39ef9f07c6bebbf060b45bd052abac8fda24f67f', href: '/users/frank.willmore/repos/hdf5_der/commits/39ef9f07c6bebbf060b45bd052abac8fda24f67f',parents: [{ id: '12a4d5640a93108ed00a2ca3ec06032a6a4a8bc6' }]},{id: '12a4d5640a93108ed00a2ca3ec06032a6a4a8bc6', href: '/users/frank.willmore/repos/hdf5_der/commits/12a4d5640a93108ed00a2ca3ec06032a6a4a8bc6',parents: [{ id: '534b3460cbd04d8e4405db87cada62a45439e7f6' }]},{id: '534b3460cbd04d8e4405db87cada62a45439e7f6', href: '/users/frank.willmore/repos/hdf5_der/commits/534b3460cbd04d8e4405db87cada62a45439e7f6',parents: [{ id: '44c2c55860d5a880c52c07088e9d6377a31ebef4' }]},{id: '44c2c55860d5a880c52c07088e9d6377a31ebef4', href: '/users/frank.willmore/repos/hdf5_der/commits/44c2c55860d5a880c52c07088e9d6377a31ebef4',parents: [{ id: '7151d3ef51162da0f9a4871844673edb8b8c6e2e' }]},{id: '7151d3ef51162da0f9a4871844673edb8b8c6e2e', href: '/users/frank.willmore/repos/hdf5_der/commits/7151d3ef51162da0f9a4871844673edb8b8c6e2e',parents: [{ id: 'c7b655e119f64abb84792e89aa3d133af682d923' }]},{id: 'c7b655e119f64abb84792e89aa3d133af682d923', href: '/users/frank.willmore/repos/hdf5_der/commits/c7b655e119f64abb84792e89aa3d133af682d923',parents: [{ id: 'bd683abe1752c6dccf897dd83fc8738d2e92020b' }]},{id: 'bd683abe1752c6dccf897dd83fc8738d2e92020b', href: '/users/frank.willmore/repos/hdf5_der/commits/bd683abe1752c6dccf897dd83fc8738d2e92020b',parents: [{ id: '6f3c8cad180321e0e8dd2f6b27db92c54d7c4d7a' }]},{id: '6f3c8cad180321e0e8dd2f6b27db92c54d7c4d7a', href: '/users/frank.willmore/repos/hdf5_der/commits/6f3c8cad180321e0e8dd2f6b27db92c54d7c4d7a',parents: [{ id: '523725e620ba30e21f783c5e71a70a3a919d43bb' }]},{id: '523725e620ba30e21f783c5e71a70a3a919d43bb', href: '/users/frank.willmore/repos/hdf5_der/commits/523725e620ba30e21f783c5e71a70a3a919d43bb',parents: [{ id: 'aae83e2e5bc442159f029e274b7d00331c30d51c' }]}]);
