Network

 
AuthorCommitMessageCommit Date
Larry KnoxLarry Knox
aae83e2e5bc[svn-r20343] Addressed Coverity issue 591 - check the return value of H5S_SELECT_ITER_RELEASE.
Allen ByrneAllen Byrne
5073a8fcc5e[svn-r20342] Fix valgrind error in H5DUMP-XML-tall.h5 Tested: local
Gerd HeberGerd Heber
7050d3392ee[svn-r20341] Added initialization udata.path = NULL; udata.visited = NULL; to prevent unintialized use after done: label. Do C-style initialization AFTER all variable definitions.
Larry KnoxLarry Knox
daa0f079721[svn-r20340] Address coverity issue 248. Set freed pointer to NULL if realloc fails, then check for NULL before attempting to close array of handles stored in memory addressed by pointer.
Allen ByrneAllen Byrne
1ede0a7f7be[svn-r20339] coverity issues: 686,828,1670-1673,1707-1711 Tested: local
Gerd HeberGerd Heber
cdc34a3561c[svn-r20338] Added udata.name = NULL; to prevent potential uninitialized use after done: label.
Gerd HeberGerd Heber
ec0900fa2bc[svn-r20337] H5O_type_t obj_type = H5O_TYPE_UNKNOWN;
Allen ByrneAllen Byrne
bd965943151[svn-r20303] Remove efc references
Allen ByrneAllen Byrne
4ad8f911307[svn-r20292] Add new cmake config files
Allen ByrneAllen Byrne
faa1b306f0a[svn-r20291] Merge cmake files from 1.8 branch r20289
Peter CaoPeter Cao
9bf2a08bc3f[svn-r20281] the follwing code cause segfault if (h5tools_detect_vlen_str(type) == TRUE) is_vlstr = TRUE;
John MainzerJohn Mainzer
2e69391db81[svn-r20280] Addressed coverity issues 927-929 & 583. The real issue is failure to check file name length -- at least at the H5FD interface level. This needs more work, but at least I have dealt with the issue in H5FDfamily.c
Gerd HeberGerd Heber
219491e4581[svn-r20278] Replaced implicit pointer conversion with (ocrt_info.new_obj != NULL).
Allen ByrneAllen Byrne
e820df1c1df[svn-r20277] Check types and close by adding error section: issue 687 Tested: jam
Allen ByrneAllen Byrne
92057cba667[svn-r20276] Add recursive is vlen string function. Cleanup resource leaks for issues: 200,202,329,688,811,812 Tested: jam
Neil FortnerNeil Fortner
a164e16dc08[svn-r20275] Purpose: Fix valgrind issue in mf.c Description: Fixed bug (incomplete if statement) in test_mf_fs_alloc_free() so the retrieved node gets freed. Tested: Fedora
Gerd HeberGerd Heber
cf29ba41d2c[svn-r20273] Addresed coverity issues 1388 and 1389. Initialized sel_iter->type to NULL in H5S_select_iter_init.
John MainzerJohn Mainzer
fb33e1d029d[svn-r20272] addressed coverity issues 838 & 955. Issue was use of strcpy() -- existing code was safe, but modified to use strncpy() to keep coverity happy.
Neil FortnerNeil Fortner
208d40367b8[svn-r20271] Purpose: Fix coverity issue 784 Description: Modified H5_debug_mask() to keep a list of files opened for use as a debugging output stream, and modified H5_term_library to close these files on exit. Tested: Fedora
Larry KnoxLarry Knox
575026a66fb[svn-r20245] Undo Jonathan/Vailin's change in revision 20235.
Jonathan KimJonathan Kim
6b6420a704a[svn-r20235] Purpose: Fixing memory leak from h5diff when compared VLstring. Bug 1904 - h5ls : usage of '-a' option is not clear to display expected output Description: The leack was caused because H5Tdetect_class() returned FALSE when detecting VLstring type as H5T_VLEN. Changed to return TRUE for VLstring type. Tested: jam (linux32-LE)
Larry KnoxLarry Knox
666d81f5df4[svn-r20234] Fix coverity issue 664. Check for NULL before dereferencing in H5Gdeprec.c.
Larry KnoxLarry Knox
02e5b830297[svn-r20233] Fix coverity issue 662. Don't try to sort 0 attributes in H5Aint.c.
John MainzerJohn Mainzer
fd80b3fdf0b[svn-r20232] Addressed coverity issues 923-925. Replaced calls to sprintf with calls to HDsnprintf.
Larry KnoxLarry Knox
935c04752a5[svn-r20191] Fixed coverity issues 643 644 and 1678 (CHECKED_RETURN).
Larry KnoxLarry Knox
5b675c0f91d[svn-r20190] Fixed Coverity issues 1561 1565 and 1678 (UNUSED_VALUES) by moving checks of return values to after the function call.
John MainzerJohn Mainzer
57381465ea5[svn-r20189] Addressed coverity defect 783. H5SL_new_node() in H5SL.c was failing to free space allocated in its first alloc if the second alloc failed. Added a call to H5FL_FREE to address this issue. This is purely to keep coverity happy -- if this code is ever triggered, we have much larger problems. Note that this fix will trigger an unused return value complaint from coverity next week.
Neil FortnerNeil Fortner
53379d4a8ff[svn-r20162] Purpose: Fix coverity issue 785 Description: Modified H5T_enum_nameof() to free "name" on failure if it was allocated. Also clarified some code in H5S_hyper_rebuild_helper(). Tested: Fedora
Vailin ChoiVailin Choi
7ec500c3dfd[svn-r20091] This is a fix for coverity bug #1683. Changed the two printfs to use %lu (unsigned long) for printing "dset_size".
Neil FortnerNeil Fortner
d093c1f5698[svn-r20085] Purpose: Fix coverity issue 793 Description: Modified H5S_hyper_project_simple_higher() to free the entire span list in new_space on failure. Tested: Fedora
Quincey KoziolQuincey Koziol
b53b46d4bc6[svn-r20072] Description: Bring r20071 from 1.8 branch to 1.8 Coverity branch: Bring r20070 from trunk to 1.8 branch: Switch order of system includes, to correct error on FreeBSD machines. Tested on: FreeBSD/32 6.3 (duty) w/debug
Larry KnoxLarry Knox
a4bc6f94896M[svn-r20068] Create new hdf5_1_8_coverity branch for coverity analysis and related codefixes.
Larry KnoxLarry Knox
6f2e1cfc407[svn-r20047] Addressed coverity issues 135-137, 462-464. Local pointers that needed to be freed in case of error were moved out of a switch statement in src/H5Tnative.c, set to NULL, and checked before freeing.
Neil FortnerNeil Fortner
35f10ae8f29[svn-r20046] Purpose: Address TOCTOU warnings in h5jam and h5unjam Description: Coverity is afraid that the state of the input file could change between the call to stat() and the call to open(). This is called a time-of- check time-of-use (TOCTOU) vulnerability. Modified stat calls to fstat which uses an open file pointer so it (hopefully) won't complain any more. Tested: Fedora
Larry KnoxLarry Knox
0f8285ed359[svn-r20039] Eliminate warnings about nested extern and implicit declarations of parallel_print and address Coverity defects 712-781 by #including h5tools_utils.h in h5diff_array.c, h5diff_attr.c, h5diff_dset.c and h5diff_util.c. Tested on jam.
Larry KnoxLarry Knox
a2ae53153fc[svn-r19980] Fix coverity issue 792. Free tmp_env_prefix in H5Lexternal.c line 365 if it is not NULL but its contents are 0 when it goes out of scope.
Peter CaoPeter Cao
127609a65f7[svn-r19976] fixed potential mem leak at H5S_hyper_project_simple_higher
Peter CaoPeter Cao
ecd63dd9566[svn-r19975] Fixed potential mem leak at H5O_attr_open_by_name
Allen ByrneAllen Byrne
83b73907769[svn-r19974] Issue #345: Inialize buf variable to null Tested: local linux
Allen ByrneAllen Byrne
de788dc1a9c[svn-r19973] Fix resource leaks by freeing string created by HD5f2string Tested: local linux
Neil FortnerNeil Fortner
8417d0c58d7[svn-r19933] Purpose: Fix memory leak in H5L_move_cb() Description: H5L_move_cb copied the source link using H5O_msg_copy() but freed it manually using H5MM_xfree(). Since H5O_link_copy allocates the link using H5FL_MALLOC, this causes the link to be allocated from the free list but is never put back on the free list when it is freed. This prevents the link free list from shutting down properly. Modified H5L_move_cb() and H5L_move_dest_cb() to free the link properly using H5O_msg_free(). ...
Neil FortnerNeil Fortner
020603f40d2[svn-r19930] Fix memory leaks involving VL attributes in h5repack and h5diff. The buffers in copy_attr and diff_attr were not checked for the presence of a vlen before being freed, and vlen storage was never reclaimed. Added checks and calls to H5D_vlen_reclaim(). Tested: Fedora (with valgrind)
Larry KnoxLarry Knox
3b4807db3ba[svn-r19834] Fixed memory leaks found by valgrind. Memory errors remain for another day.
Jonathan KimJonathan Kim
858b182ec5f[svn-r19778] Purpose: Fix memory leak comparing for variable length data types. Description: Tested: jam (linux32-LE)
Peter CaoPeter Cao
dabc420cabf[svn-r19775] removed unused variables
Peter CaoPeter Cao
55d2c57fbdf[svn-r19774] removed unused priv.
Peter CaoPeter Cao
79177d0a81e[svn-r19773] removed unused tmp_buf at the end
Peter CaoPeter Cao
d8a1720dfcd[svn-r19772] Change H5assert() to if (H5T_VLEN != src->shared->type || H5T_VLEN != dst->shared->type) HGOTO_ERROR(H5E_ARGS, H5E_BADTYPE, FAIL, "not a H5T_VLEN datatype")
Neil FortnerNeil Fortner
8f02c9d1b55[svn-r19736] Fix memory leak in h5repack. The buffer in copy_objects, when copying the entire dataset at once, was not checked for the presence of a vlen, and vlen storage was never reclaimed. Added check and call to H5D_vlen_reclaim(). Tested: Fedora
Larry KnoxLarry Knox
be600431499[svn-r19735] Fix for memory leak in test/mf found by valgrind. Tested on jam.