• Skip to sidebar navigation
  • Skip to content

Bitbucket

  • More
    ProjectsRepositories
  • Help
    • Online help
    • Learn Git
    • Welcome to Bitbucket
    • Keyboard shortcuts
  • Log In
Scot Breitenfeld
  1. Scot Breitenfeld

hdf5_msb

HDF5
hdf5
Public
Actions
  • Clone
  • Download

Learn more about cloning repositories

You have read-only access

Navigation
  • Source
  • Commits
  • Graphs
  • Branches
  • Network
  • Latest Activities

Commits

Pedro Vicente Nunes
5e8d84b4214
Participant
    Watch this commit
    Tag this commit
    Pedro Vicente Nunes committed 41b80569d7616 Jun 2009
    [svn-r17058] added some "dummy" declarations for d_status
    
    this error
    home/hdftest/snapshots-hdf5/current/tools/lib/h5tools_ref.c:126: undefined reference to `d_status'
    
    happens because the original developer of h5tools_ref.c declared these 2 variables in that source file
    
    extern char   *progname;
    extern int    d_status;
    
    this means that all programs that use this source file (typically all tools) will have to define these 2 variables, even if they are *not* used. 
    
    examples
    
    const char *progname = "h5jam";
    int d_status = EXIT_SUCCESS;
    
    "progname" is usually used to print the program name in the usage, and "d_status" is just a return value of the tool, usually.
    
    I was wondering about removing these 2 declarations from h5tools_ref.c
    
    extern char   *progname;
    extern int    d_status;
    
    and define those variables on each tool if they are only needed (it seems to me that only h5ls and h5dump actually "need" them)
    
    tested: smirom parallel
    • Git repository management for enterprise teams powered by Atlassian Bitbucket
    • Atlassian Bitbucket v4.4.1
    • Documentation
    • Contact Support
    • Request a feature
    • About
    • Contact Atlassian
    Atlassian
    ยป