• Skip to sidebar navigation
  • Skip to content

Bitbucket

  • Projects
  • Repositories
    • View all public repositories
  • Help
    • Online help
    • Learn Git
    • Welcome to Bitbucket
    • Keyboard shortcuts
  • Log In
David Young
  1. David Young

vchoi_fork

Vailin Choi
my_hdf5_fork
Public
Actions
  • Clone
  • Download

Learn more about cloning repositories

You have read-only access

Navigation
  • Source
  • Commits
  • Graphs
  • Branches
  • Network
  • Latest Activities

Commits

Bill Wendling
36a0b8e3dd1
Bill Wendling committed db543f1a23107 May 2003
[svn-r6823] Purpose:
    Code Improvements/Bug Fixes

Description:
    Comparison of equality of a double/float variable to 0.0 is not
    guaranteed to work and is bad practice.

    In H5Fcontig.c, a warning was given by a statement like:

        x = (++x) % y;

    This could be confusing to a compiler I suppose.

    In H5RS.c, a typedef of a structure was being tagged by the compiler
    as "useless" because it had the form:

        typedef struct foo {
            int var1;
            /* ... */
        }; /* <--- note no name for this typedef */

    The statement "typedef struct foo foo" is already in the header file.

Solution:
    Test that the absolute value of the variable is < a very small
    positive number.

    Changed "x = (++x) % y" to "++x; x %= y;" instead.

    Removed the "typedef" from the structure in the H5RS.c file.

Platforms tested:
    Modi4   (Parallel & Fortran)
    Verbena (C++ & Fortran)
    Arabica (Fortran)

Misc. update:

Changed files

  • Git repository management for enterprise teams powered by Atlassian Bitbucket
  • Atlassian Bitbucket v4.4.1
  • Documentation
  • Contact Support
  • Request a feature
  • About
  • Contact Atlassian
Atlassian