[svn-r19237] Description: Clean up misc. compiler warnings.Tested on:
FreeBSD/32 6.3 (duty) in debug mode
Mac OS X/32 10.6.4 (amazon) w/C++ & FORTRAN, w/threadsafe,
in production mode
Mac OS X/32 10.6.4 (amazon) w/parallel, in debug mode
[svn-r19236] Description: Clean up compiler warnings and misc. style issues with new internal tagged entry code.Tested on:
FreeBSD/32 6.3 (duty) in debug mode
Mac OS X/32 10.6.4 (amazon) in debug mode
Mac OS X/32 10.6.4 (amazon) w/C++ & FORTRAN, w/threadsafe,
in production mode
Mac OS X/32 10.6.4 (amazon) w/parallel, in debug mode
[svn-r19235] Description: Bring r19234 from the 1.8 branch to the trunk: Initialize loop variable that caused failures in certain circumstances.
Also clean up compiler warnings and release MPI datatype.
Tested on:
FreeBSD/32 6.3 (duty) in debug mode
FreeBSD/64 6.3 (liberty) w/C++ & FORTRAN, in debug mode
Linux/32 2.6 (jam) w/PGI compilers, w/default API=1.8.x,
w/C++ & FORTRAN, w/threadsafe, in debug mode
Linux/64-a...
[svn-r19230] Reset alarm_seconds back to 20 minutes.Description:
honest3 v1.8 failed in parallel test. It got stuck in the same
testpar/testphdf5 subtest (cbhsssdrpio). This is an old problem.
Upon closer inspection, the testphdf5, when terminated, had clocked
up 1hr 9min 46 sec wall clock time. Honest1 system also sent a message
that an mpi process has used up 30+ CPU minutes which exceeded their login
node cpu time limit and they killed the...
[svn-r19228] File read/write happens at configure time, so moved windows specific copy from test macro to where the expected file is copied.Tested: windows
[svn-r19225] Moved subfolder checked outside of OPTION command. If folder doesn't exists, there is no reason to have option enabled.Tested: local linux
[svn-r19222] Move hl fortran ADD_SUBDIRECTORY to right after fortran ADD_SUBDIRECTORY. This fixes a problem with compiler generated files not including target module directory on some linux machines. Corrected minor format/location of commands.Tested: local linux
[svn-r19217] Bug 1986, error1.It is an error to use the condition H5_HAVE_FSEEK64 to control the definition
of HDlseek. It caused errors in AIX where lseek64 is available.
Replaced it with H5_HAVE_LSEEK64. Also added the missing HDstrcasecmp macro.
Tested: AIX using default and --disable-largefile.
[svn-r19214] Test for compare of output text to expected needed to account for windows line endings.Moved ADD_TEST commands to macro.
Tested: local linux, windows
[svn-r19205] Bug 1917: post cleanup.fseek64 was used to support large file access for the STDIO driver back in
version 1.2.2 in year 2000. Some how it was not included in version 1.4.0.
Now, fseeko64 is used to support large file. There is no more need for fseek64
which is not a standard call. Removed its presence from configure and related
files.
Tested: jam for configure only.
[svn-r19202] [BZ1953]implementation for the proposed changes suggested by the "h5dump_output_option" RFC. This required that the region reference code be duplicated and reduced to allow the do_bin_output() function to understand region references. The container type-id also needed to be propagated into the do_bin_output() function and functions referenced (render_bin_output*).Existing tests tested the binary function, so only one test was added to test the region reference generated file.
Tested: local linux
[svn-r19201] Added tests that subdirectories exist before using ADD_SUBDIRECTORY CMake command Added cache set command for default install prefixTested: local linux
[svn-r19188] Bug fix: ID 1917The STDIO only checked for fseeko and incorrectly assumed it can support file
sizes larger than 32bits. Fixed it by making to use fseeko64 if supported, else
use fseeko. To simplify the code, assume fseeko which is a POSIX function must
be supported. Therefore, fseek is not used at all.
(Note: the above applies to Unix-like system. The Windows platform has
hardcoding using Windows functions w...
[svn-r19185] Bug fix: ID 1917In some machine (Linux), when --disable-largefile is used, it claims it has
fseeko64 but off64_t is NOT supported. Moved the test of fseeko64 and ftello64
to where fseek64 is so that they are tested only if off64_t is supported.
Tested: h5committested.
[svn-r19179] Description: Bring changes from Coverity branch back to trunk:r19079 & 19080:
[BZ1942] h5dump -u to generate XML, it does not respect the -m option
xml version of dump_data function didn't check for use of fp_format variable.
Added new test expected file for committed bug 1942
r19103, 19104 & 19105:
[BZ1821] h5repack -v did not display correct output for a selected compression. Needed new test for comparing output of -v option.
Added new test file fo...
[svn-r19176] Bug fix for #1239 - The filter's public function CAN_APPLY should return htri_t not herr_t. To minimize the change of the library's behavior, in the function H5Z_prelude_callback of H5Z.c, if the return value of can_apply is FALSE and the filter is MANDATE, this function returns a FAILURE. If the return value is FALSE but the filter is OPTIONAL, this function returns a SUCCEED. ...Tested the same change for 1.8 on jam, linew, and amani. Tested on jam with szip.
[svn-r19175] Bug fix for #1239 - The filter's public function CAN_APPLY should return htri_t notherr_t. To minimize the change of the library's behavior, in the function
H5Z_prelude_callback of H5Z.c, if the return value of can_apply is FALSE and
the filter is MANDATE, this function returns a FAILURE. If the return value is FALSE
but the filter is OPTIONAL, this function returns a SUCCEED. During the IO, the filter
will fail and return a size of zero. But the pipeline will skip this f...
[svn-r19174] Bug fix for #1239 - The filter's public function CAN_APPLY should return htri_t not herr_t. To minimize the change of the library's behavior, in the function H5Z_prelude_callback of H5Z.c, if the return value of can_apply is FALSE and the filter is MANDATE, this function returns a FAILURE. If the return value is FALSE but the filter is OPTIONAL, this function returns a SUCCEED...Tested on jam, lnew, and amani. Tested on jam with szip.
[svn-r19171] Bug fix: 1917.The previous fix had the Windows code in H5private.h but they should have been
in H5win32defs.h which holds all Windows-specific definitions. Moved the fix.
Tested: BP (AIX) to confirm the fix is still valid. Windows tests will occur
in daily tests tonight.
[svn-r19167] Bug fix: 1917.Description:
test/big incorrectly determined not able to write files larger than 2GB and
skipped the SEC2 and STDIO driver tests. The reason was because it was using
off_t while the SEC2 driver is using lseek64 which expects off64_t type.
Solution:
Created a new HDoff_t which is set to off_t or off64_t or other appropriate
type depending on which of lseek or lseek64 is available. Changed SEC2...
[svn-r19160] Added the tests for fseeko64 and ftello64 which will be used by the STDIO VFD if they are available.Tested: jam only since it was tests for two new functions that are not used by
the code yet.
[svn-r19156] Description: Bring revisions from Coverity branch back to trunk:r19044:
Coverity #449 - Line 1560 called function H5O_chunk_protect for 2 pointers to allocate. But when there's failure on the second one, the first wasn't freed
(H5O_chunk_unprotect). We fixed it by freeing the pointers when an error happens.
r19045:
Fixed coverity issue # 319. Free sec_node in done if it is not NULL.
r19046:
Add intended but missing assignments to initialize pointers to...
[svn-r19153] Description: Bring changes on Coverity branch back to trunk:r19040:
Fixed coverity #440 - NULL check after dereference. We moved the NULL check up
into the IF block and changed it to assertion.
r19041:
Maintenance: Addressed Coverity issues 441 and 449 by initializing proper
variables
r19042:
In function H5O_chunk_protect (H5Ochunk.c):
- Initialize H5O_chunk_proxy_t pointers chk_proxy and ret_value.
- Free chk_proxy on error.
r19043:
Addressed cov...
[svn-r19150] Correction from the previous checkin for H5Oattribute.c. Because the attribute structure i is shared now. The only situation that requires copying the data is when the metadata cache evicts and reloads this attribute. The attribute structure will be different in that situation. Tested on jam.
[svn-r19148] Maintenance: Removed misleading information about the HDF4-to-HDF5 tools. The tools became a part of the h4h5tools distribution long time ago, but the INSTALL file
was not updated in the development branch and slipped into 1.8 releases and current trunk.
[svn-r19146] Purpose: Fix bug in direct IO driverDescription:
In certain circumstances, the direct I/O driver did not perform correctly when
data was unaligned. The driver has been patched to fix this. Also added some
potential performance improvements for the unaligned case, and strengthened the
test for whether the data needs to be aligned.
Tested: cobalt
[svn-r19140] In line 861, there's no need to allocate data buffer or copy the data because the attribute structure is shared now. Only do an assertion check, instead.Tested the same change for 1.8.5 on jam - simple change.
[svn-r19133] Description: Correct traversal of user-defined links (including external links) to retain path information of object, allowing H5Iget_name() queries to work quickly (without searching entire destination file). This required some refactoring and addition of a mechanism to detect if a "fast" query was performed (for the tests). Minor code cleanups, etc.
Tested on:
FreeBSD/32 6.3 (duty) in debug mode
FreeBSD/64 6.3 (liberty) w/C++ & FORTRAN, in debug mode
Linux/32 2.6 (jam) w/PGI compilers, w/default API=1.8.x,
w/C++ & FORTRAN, w/threadsafe, in debug mode
Linux/64-amd64 2.6 (amani) w/Intel compilers, w/default API=1.6.x,
w/C++ & FORTRAN, in production mo...
[svn-r19131] Description: Reduce compiler optimizations for v10.6, to work around bug with static constant char *'s.Tested on:
Linux/32 2.4 (jam) w/PGI
[svn-r19130] Description: Correct another inadvertant use of macro instead of versioned API name.Tested on:
Eyeballed only, too minor to require h5committest
[svn-r19127] Description: Change use of API wrapper to using versioned API routine (i.e. H5Eprint -> H5Eprint2)Tested on:
None, eyeballed only, too simple
[svn-r19114] Description: Rename H5AC_set() to H5AC_insert_entry() Get rid of H5C_set_skip_flags() & related flagsTested on:
Mac OS X/32 10.6.4 (amazon) w/debug, production & parallel
(too simple to require h5committest)
Quincey Koziol
Albert Cheng
Allen Byrne
Raymond Lu
Elena Pourmal
Neil Fortner