[svn-r18193] I added a test for copying an existing DCPL and using the copy to create a new dataset. There's a bug report (#1608) saying h5repack failed to do that sometimes. But I couldn't reproduce it. So I added this test and closed the report. The test is in the function test_copy_dcpl in dsets.c.Tested on jam. But I tested the same change in 1.8 on jam, amani, and linew.
[svn-r18174] Bug ID 1753: added macro version of GetTestVerbosity.The previous implementation did not work for WIndows.
Moved the macro definition of HDGetTestVerbosity from testhdf5.h
to h5test.h.
Removed as much as possible macro definitions that use HDGetTestVerbosity
directly.
Tested: Jam (serial and parallel). Did not run h5committest since this
is a trival change that is portable.
[svn-r18170] Skipped 3 test cases for parallel mode which caused hang. They are external-link test cases with following link option. The related code was checked in as svn #18164 and #18165 to support follwing links for h5diff. The test cases will be added back when find solution for parallel mode.Tested on Jam
[svn-r18166] Purpose: Take care of test case fail for h5repack from checkin (r18164)Description:
Previous checkin didn't allow h5diff to return succeed when a link's
target object doesn't exist. Changed it to succeed with warning.
(Need to discuss related feature)
Tested on Jam
[svn-r18165] Purpose: Add test cases for h5diff check-in (svn revision #18164).Description:
This test cases are for testing comparing through various link combinations
relate to bugzilla report 1754.
Also improved the test script to handle external link cases and
simplified to use single line instead of double for each test cases.
Tested on Jam
[svn-r18164] Purpose: Add a feature to compare through links. Relate to bugzilla report 1754.Description:
Currently, h5diff command only compares the name(path) of target object
not the actual data. With this feature, h5diff will go through the link(s)
and figure out the actual object at the end of the link and compare data
if exist. Internally we have hard-link, soft-link, external-link (as part
of user_defined-link). This feature will provide a user transparen...
[svn-r18159] Description: Bring Coverity fixes from 1/22/10 session to trunk:r18137:
219: Initialized hid_t to -1 and added close to error block.
189-191: Initialized line to NULL and added free line, and close fp to error block.
r18138:
19: Moved code block for printing that the number of enums is empty to the error block. (Would never have been executed otherwise)
r18139:
Fix coverity item 58. Moved code related to displaying the parent of a repeated
group to the e...
[svn-r18157] Description: Bring back changes from Coverity session on 1/15/10:r18111:
Fix Coverity issue #130: make certain that the cache gets freed on error.
r18112:
Fix Coverity issue #43 by making cache testing calls protected by 'pass'
variable.
r18113:
Fix Coverity issue #129 by releasing the cache on error.
r18115:
Coverity #45 fix: patched an error check in H5Screate_simple to prevent future dereferencing of a NULL point.
Added a verification in test/th5s.c.
...
[svn-r18154] ID 1753: added macro version of GetTestVerbosity.GetTestVerbosity() is called many times during tests. Implemented a more
efficient macro version HDGetTestVerbosity.
Tested: Jam (serial and parallel). Did not run h5committest since this
is a trival change that is portable, I am 99% sure.
[svn-r18134] Purpose: Additional fix relted to the fix of bug1672.Description:
The fix of bug1672 caused some changes of output which required modifying
some test cases. After some discussion, restoring the changes of the test
cases was decided. After many experiments for the solution, this fix was
made so the code which improved performance can stay.
Tested on Jam.
[svn-r18125] I added the support of bitfield in H5Tget_native_type. Bitfield is similar to unsigned integer. I also added a test.Tested on jam. But I tested the same change for 1.8 with h5committest.
[svn-r18109] Description: Bring r18076-18096 from hdf5_1_8_coverity branch to trunk:r18076:
Correct Coverity issue #1 by removing dead code
r18077:
Fix coverity item 142. When an error occurred while copying a linked list in
H5S_point_copy, the library would not free the partially allocated list. Added
code to free the list in this case.
r18078:
Correct Coverity issue #2 by removing impossible to reach code.
r18079:
Correct #3 by removing impossible to reach code.
r18080...
[svn-r18107] bug 1673: The mixed use of RUNTEST (original) and RUNTESTS (new) caused confusion. E.g., the timings in test/ was still using the old $RUNTEST. It made more sense to use $RUNTEST which is used by the dejagnu feature of automake. So, I changed all $RUNTEST or $RUNTESTS to $RUNEXEC.config/commence.am & config/conclude.am are the two files
that got changes. Also fixed an error in test/Makefile.am.
The rest are changed by bin/reconfigure.
Tested: h5committested.
[svn-r18098] Description:Changed the link type definitions to match the changes made in the source.
- ! H5L_LINK_SOFT_F - Soft link
- ! H5L_LINK_EXTERNAL_F - External link
- ! H5L_LINK_ERROR _F - Error
+ ! H5L_TYPE_HARD_F - Hard link
+ ...
[svn-r18097] Desciption:Changed comments to reflect changes made to the link_type names to match those in C (bug 1720) from,
H5L_LINK_HARD_F, H5L_LINK_SOFT_F,H5L_LINK_EXTERNAL_F,H5L_LINK_ERROR_F
to
H5L_TYPE_HARD_F, H5L_TYPE_SOFT_F,H5L_TYPE_EXTERNAL_F,H5L_TYPE_ERROR_F
MSB January 8, 2010.
Tested: No source changed.
[svn-r18072] Description: Bring r18071 from metadata journaling merge branch: Refactor local heap routines with changes from metadata journaling
branch, along with other misc. changes as the changes on the metadata journaling
branch are being converged with the current state of the trunk.
Tested on:
FreeBSD/32 6.3 (duty) in debug mode
FreeBSD/64 6.3 (liberty) w/C++ & FORTRAN, in debug mode
Linux/32 2.6 (jam) w/PGI compilers, w/default API=1.8.x,...
[svn-r18057] Bug fix: 1192Description:
Fixed exit code (sometimes return code in Main) to follow the HDF5 standards.
Tested:
Jam, both serial and parallel.
[svn-r18055] Bug fix: 1192Description:
Fixed exit code (sometimes return code in Main) to follow the HDF5 standards.
Tested:
H5committested plus serial test in Jam.
[svn-r18051] Bug fix: 1192Description:
Some exit code (sometimes return code in Main) to follow the HDF5 standards.
Tested:
H5committested plus serial test in Jam.
[svn-r18045] Description: Slush changes back & forth between trunk, the merging branch and the metadata journaling branch to level them out to a reasonably common set of code to work from for the next set of more significant changes.Tested on:
Mac OS X/32 10.6.2 (amazon) w/debug
(h5committest not required on this branch)
[svn-r18039] Description: Minor code cleanups, to align better w/ongoing metadata journaling convergence.Tested on:
Mac OS X/32 10.6.2 (amazon) w/debug
(too minor to require h5committest)
[svn-r18035] Description: More "brush clearing" convergence between metadata_journaling branch and the trunk.Tested on:
Mac OS X/32 10.6.2 (amazon) debug & prod
(h5committest not required on this branch)
[svn-r18031] Description: Bring r18030 from merge_metadata_journaling branch to trunk: Bring "brush clearing" changes (whitespace & style issues, mostly) from
metadata_journaling branch to the "merging" branch, to converge the trunk and
the metadata_journaling branch.
Also, some other minor cleanups along the way.
Tested on:
FreeBSD/32 6.3 (duty) in debug mode
FreeBSD/64 6.3 (liberty) w/C++ & FORTRAN, in debug mode
Linux/32 2.6 (jam) w/PGI compilers, w...
[svn-r18028] On Boeing's OpenVMS, the value of EXIT_FAILURE is 268435458. (The test is in test_exit_definitions.) Their document says it's supposed to be 2. I commented it out for further consideration.Tested 1.8 branch on jam - simple change.
[svn-r18025] I removed a duplicated line from the read_old function. There were 2 identical calls to the function H5Fopen.Tested v1.8 branch on jam and the release 1.8.4 on OpenVMS.
[svn-r18011] Description: Bring Coverity changes into the trunk: (also other minor cleanups)r17991:
Fix Coverity items 175 and 176. Fixed memory leak on error in print_enum in
H5LT.c.
r17993: (r17992 was not a Coverity change)
Close Coverity issue #206: inconsistently checking whether dt->shared was
non-NULL after H5T_alloc() returned a valid 'dt' value (which should guarantee
that dt->shared is valid).
r17994:
Fix Coverity item 149. Fixed file handle leak on error in H5FD_stdio_o...
[svn-r17981] Description: Abstract "print header" code into separate routine.Tested on:
Mac OS X/32 10.6.2 (amazon) w/debug
(too minor to require h5committest)
[svn-r17978] Description: Simplify checking for detecting variable-length strings.Tested on:
Mac OS X/32 10.6.2 (amazon) debug & production
Too minor to require h5committest
[svn-r17977] Bug fix for 1584. H5Tdetect_class said a VL string is a string type. But when it's in a compound type, it says it's a VL type. We want to tell user a VL string is a string. But internally we treat it as a VL type. I added a flag as a parameter of H5T_detect_class. It tells whether the caller is the public function H5Tdetect_class. I also added a detection for VL string in ...Tested on jam and amani - I tested the same change for 1.8 with h5committest.
Quincey Koziol
Raymond Lu
Albert Cheng
Jonathan Kim
Private HDF
Allen Byrne
Scot Breitenfeld
Larry Knox