Last cleanup of code before official release v1.2.0. Update version information for official release.Tested: all Unix THG development machine except Fred.h5edit_1_2_0
Bug fix: RENAME was not working.A line to assign attribute_name to attribute_name_new was missed, making
attr_name_new incorrect. Fixed.
Also cleaned out some old, not applicable code for the MODIFY command.
Tested: koala.
Bug fix: When an attribute of the root group (e.g. /attr2 ) is modified, the command fails to open the attached object ("/") because the code tried to open it by H5Dopen() first.Solution:
Changed modify to use H5Oopen/H5Oclose to open/close all dataset
or group objects. This not only fix the bug, it also simplifies
the code in the routine.
Tested: koala.
src/modify_cmd.c:
code simplified for the solution above.
test/testh5edit.sh:
test/testfiles/modify-atts12-dset111.ref:
Added the "MODIFY /attr2 ..." test to verify the solution.
Changed the expect output t...
Simplify the code for MODIFY command syntax to just one modify_cmd rule. Normally, object and attribute names are as two separated tokens. But if they are given as one combined token (<object/attribute>), it is splitted by split_object_attribute() function. This reduces a lot of duplicated code.Tested: koala.
New Feature: adding MODIFY command.Initial version check in. More work is needed.
Tests passed in Jam, Koala, Ostrich, Emu, Duck, Wren, Platypus.
RENAME is failing and its tested are temporay skipped in testh5edit.sh.
src/modify_cmd.c:
new source module to hand the MODIFY command.
src/Makefile.am:
src/Makefile.in:
addition of modify_cmd.c source module to support the MODIFY command.
test/testh5edit.sh:
Added MODI...
Post v1.1.0 release aintenance. configure: configure.ac: src/h5edit.h: README: Changed to version number to 1.1.0-post1. doc/History: Archived RELEASE.txt into History. doc/RELEASE.txt: Reset RELEASE.txt for next release. bin/setversion: added examples into the remark section.Tested: only in Jam since changes are mostly simple text.
configure.ac: Added copyright notice. test/Makefile.in: test/Makefile.am: Makefile.in: Makefile.am: Updated Copyright to 2013.Tested: eyeballed only since all changes are in comment form, no code change.
Bug fix: if the datafile argument is not a simple file name in the current directory, e.g., testfile/datafile.h5, h5edit did not handle it correctly.Fixed the backup file creation function to handle "remote" datafile.
Tested: all 6 platforms (jam, koala, ostrich, emu, duck and wren).
Fixed test case for data file in non-current directory; previous test assumed source and build directory were the same. Note that the test will still fail due to the outstanding bug.Tested on: koala, jam
Added a test for a datafile that is not in the current working directory. (This test will fail until the backup file creation code is fixed.)Tested: koala (Linux 64-bit)
New feature: Add support for "RENAME <targetobject/old_attributename> <new_attributename>"test/testh5edit.sh:
Unskipped the tests for the new feature. They were implemented before but
were skipped to let "make check" to pass.
src/parse.y:
src/parse.c:
Added support of the new syntax for RENAME command. Added both attribute_name_old
to hold the old attributename. "attribute_name" holds an attribute name temporary
until it is copied to the new or old attribute nam...
Portability fixes: 1. SunOS' native tail does not support -n. Changed to use sed to do filtering. 2. "==" is not legal for SunOS' test command. Changed to "=".Tested: jam, koala, linew, ostrich, duck, wren. All passed.
Added Mac OS X 10.7.5 and 10.8.2 to the list of supported platforms.
The addition of new source module copy_cmd.c should been added to Makefile.am and then Makefile.in is generated by running bin/reconfigure. Just make the change properly and commit them.Tested: Jam.
New feature: Added edit command RENAME. This one accepts the syntax of RENAME <object> <old attribute> <new attribute>. It does not accept the combined <object>/<old attribute> yet.test/testfiles/rename-atts12-grrt.edit:
test/testfiles/rename-atts12-dset111.edit:
test/testfiles/rename-atts12-grrt.ref:
test/testfiles/rename-atts12-dset111.ref:
test/testh5edit.sh:
src/parse.y:
src/analyze.c:
src/parse.c:
src/analyze.l:
src/parse.h:
src/h5edit.h:
Add command parsing for RENAME.
src/rename_copy_cmd.c:
Add rename_attribute().
src/Makefile.am:
src/Makefile.in:
Add ...
Albert Cheng
Joel Plutchak
Elena Pourmal